Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi select behavior in Media Manager followup of 39824 #44747

Open
wants to merge 28 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

MacJoom
Copy link
Contributor

@MacJoom MacJoom commented Jan 18, 2025

Pull Request for Issue #33637
This is a followup of #39824

All the credits go @rajputanuj31 - i just fixed the conflicts and could not do it against his PR

Summary of Changes

In Media Manager selecting multiple files with the ctrl key does not work - this is fixed with this PR

Testing Instructions

Go to Media Manager try to select multiple files with the CTRL key

Actual result BEFORE applying this Pull Request

Already selected file is unselected, not possible to select multiple files this way

Expected result AFTER applying this Pull Request

Selecting multiple files is possible

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Jan 18, 2025
@richard67
Copy link
Member

@MacJoom Does this PR replace #39824 so the latter should be closed?

@MacJoom
Copy link
Contributor Author

MacJoom commented Jan 18, 2025

@MacJoom Does this PR replace #39824 so the latter should be closed?

Yes can be closed - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants