Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Global Configuration: Link SEO to SEF plugin #44749

Open
wants to merge 18 commits into
base: 5.3-dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3bd27c4
Display the correct changelog when updating (#44652)
Hackwar Jan 12, 2025
8ca71b9
#44636 add scroll-margin-top if sticky top is used (#44679)
hans2103 Jan 12, 2025
70b79ce
[5.2] Fix assets for com_scheduler (new install) (#44684)
heelc29 Jan 12, 2025
53dc17d
[5.2] Fix PHP Warning for debuguser, debuggroup (#44721)
chmst Jan 12, 2025
e9bbd2a
[5.2.3] Removing deprecated access to User object attributes (#44694)
heelc29 Jan 12, 2025
6860792
[5.2] Translation Update (#44712)
joomla-translation-bot Jan 12, 2025
ad4b0c1
[5.2] copypaste @package (#44706)
brianteeman Jan 13, 2025
ffbad2e
[5][com_user] debug user untranslated string (#44688)
alikon Jan 13, 2025
fea4552
[5.2] system test for list multiselect checkboxes (#44720)
heelc29 Jan 15, 2025
ecb5151
[5.2] Fix for: Article cannot be saved successfully on the front-end …
NicolasDerumigny Jan 17, 2025
276c7a1
[5.2] Fix missing brackets (#44739)
janschoenherr Jan 17, 2025
9059475
[5.2] Unable to store null value on update row #39363 (#39607)
Kaushik1216 Jan 18, 2025
5df5fc4
[5.2] Finder Router: filter out unnecessary query elements (#44055)
Hackwar Jan 18, 2025
65acec1
[5.2] Check whether there is a language file from the frontend (#44730)
zero-24 Jan 18, 2025
20d3804
[5.2] Fix password reset broken in backend (#44723)
joomdonation Jan 18, 2025
3f9497b
[5.2] Update index.php - Installation template (#43416)
sinahaghparast Jan 18, 2025
dae8491
[5.2] Global Configuration: Link SEO to SEF plugin
pe7er Jan 18, 2025
639231a
Merge branch '5.3-dev' into global-config-link-sef-plugin
pe7er Jan 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions administrator/components/com_installer/src/Model/ManageModel.php
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,16 @@ public function loadChangelog($eid, $source)
]
)
)
->select($db->quoteName('updates.version', 'updateVersion'))
->select($db->quoteName(
[
'updates.version',
'updates.changelogurl',
],
[
'updateVersion',
'updateChangelogUrl',
]
))
->from($db->quoteName('#__extensions', 'extensions'))
->join(
'LEFT',
Expand All @@ -423,13 +432,15 @@ public function loadChangelog($eid, $source)
$this->translate($extensions);
$extension = array_shift($extensions);

if (!$extension->changelogurl) {
$changelogurl = $source === 'manage' ? $extension->changelogurl : $extension->updateChangelogUrl;

if (!$changelogurl) {
return '';
}

$changelog = new Changelog();
$changelog->setVersion($source === 'manage' ? $extension->version : $extension->updateVersion);
$changelog->loadFromXml($extension->changelogurl);
$changelog->loadFromXml($changelogurl);

// Read all the entries
$entries = [
Expand Down
4 changes: 4 additions & 0 deletions administrator/components/com_mails/src/Helper/MailsHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ public static function loadTranslationFiles($extension, $language = 'en-GB')
case 'com':
default:
$source = JPATH_ADMINISTRATOR . '/components/' . $extension;

$lang->load($extension, JPATH_BASE, $language, true)
|| $lang->load($extension, JPATH_BASE . '/components/' . $extension, $language, true);

break;

case 'mod':
Expand Down
4 changes: 4 additions & 0 deletions administrator/components/com_users/src/Helper/DebugHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ public static function getDebugActions($component = null)
$component_actions = Access::getActionsFromFile(JPATH_ADMINISTRATOR . '/components/' . $component . '/access.xml');

if (!empty($component_actions)) {
// Load language
$lang = Factory::getApplication()->getLanguage();
$lang->load($component, JPATH_ADMINISTRATOR, null, false, false);

foreach ($component_actions as &$action) {
$descr = (string) $action->title;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
<?php else : ?>
<?php
// Split the actions table
$loginActions = [];
$actions = [];
foreach ($this->actions as $action) :
$name = $action[0];
if (in_array($name, ['core.login.site', 'core.login.admin', 'core.login.offline', 'core.login.api', 'core.admin'])) :
Expand Down
5 changes: 2 additions & 3 deletions administrator/components/com_users/tmpl/debuguser/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
$listOrder = $this->escape($this->state->get('list.ordering'));
$listDirn = $this->escape($this->state->get('list.direction'));

$loginActions = [];
$actions = [];

/** @var Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->getDocument()->getWebAssetManager();
$wa->useScript('table.columns');
Expand All @@ -39,6 +36,8 @@
<?php else : ?>
<?php
// Split the actions table
$loginActions = [];
$actions = [];
foreach ($this->actions as $action) :
$name = $action[0];
if (in_array($name, ['core.login.site', 'core.login.admin', 'core.login.api', 'core.login.offline'])) :
Expand Down
2 changes: 1 addition & 1 deletion administrator/language/en-GB/com_config.ini
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ COM_CONFIG_SENDMAIL_METHOD_SMTP="SMTP"
COM_CONFIG_SENDMAIL_SUBJECT="Test mail from {SITENAME}"
COM_CONFIG_SENDMAIL_SUCCESS="The email was sent to <strong>%s</strong> using <strong>%s</strong>. You should check that you've received the test email."
COM_CONFIG_SENDMAIL_SUCCESS_FALLBACK="The email was sent to <strong>%s</strong> but using <strong>%s</strong> as fallback. You should check that you've received the test email."
COM_CONFIG_SEO_SETTINGS_DESC="Additional settings can be found in the \"System - SEF\" plugin."
COM_CONFIG_SEO_SETTINGS_DESC="Additional settings can be found in the <a class=\"alert-link\" href=\"index.php?option=com_plugins&view=plugins&filter[folder]=system&filter[element]=sef\">\"System - SEF\"</a> plugin."
COM_CONFIG_SEO_SETTINGS="SEO"
COM_CONFIG_SERVER="Server"
COM_CONFIG_SERVER_SETTINGS="Server"
Expand Down
2 changes: 1 addition & 1 deletion build/media_source/com_content/js/form-edit.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
document.querySelectorAll(`[${buttonDataSelector}]`).forEach((button) => {
button.addEventListener('click', (e) => {
e.preventDefault();
const task = e.target.getAttribute(buttonDataSelector);
const task = button.getAttribute(buttonDataSelector);
submitTask(task);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
@media screen and (prefers-reduced-motion: reduce) {
scroll-behavior: auto;
}

&:has(.sticky-top) {
[id] {
scroll-margin-top: var(--cassiopeia-scroll-margin-top, 10rem);
}
}
}

html {
Expand Down
33 changes: 31 additions & 2 deletions components/com_finder/src/Service/Router.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
use Joomla\CMS\Component\Router\RouterViewConfiguration;
use Joomla\CMS\Component\Router\Rules\MenuRules;
use Joomla\CMS\Component\Router\Rules\NomenuRules;
use Joomla\CMS\Component\Router\Rules\StandardRules;
use Joomla\CMS\Menu\AbstractMenu;

// phpcs:disable PSR1.Files.SideEffects
Expand Down Expand Up @@ -43,7 +42,37 @@ public function __construct(SiteApplication $app, AbstractMenu $menu)
parent::__construct($app, $menu);

$this->attachRule(new MenuRules($this));
$this->attachRule(new StandardRules($this));
$this->attachRule(new NomenuRules($this));
}

/**
* Build method for URLs
*
* @param array &$query Array of query elements
*
* @return array Array of URL segments
*
* @since __DEPLOY_VERSION__
*/
public function build(&$query)
{
$segments = [];

// Process the parsed variables based on custom defined rules
foreach ($this->rules as $rule) {
$rule->build($query, $segments);
}

if (isset($query['Itemid'])) {
$item = $this->menu->getItem($query['Itemid']);

if ($query['option'] == 'com_finder' && isset($query['f']) && isset($item->query['f']) && $query['f'] == $item->query['f']) {
unset($query['f']);
}
}

unset($query['view']);

return $segments;
}
}
2 changes: 1 addition & 1 deletion components/com_users/src/Controller/CallbackController.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/Controller/CaptiveController.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/Controller/MethodController.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/Controller/MethodsController.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
10 changes: 5 additions & 5 deletions components/com_users/src/Dispatcher/Dispatcher.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

/**
* @package Joomla.Site
* @subpackage com_privacy
* @subpackage com_users
*
* @copyright (C) 2024 Open Source Matters, Inc. <https://www.joomla.org>
* @license GNU General Public License version 2 or later; see LICENSE.txt
Expand All @@ -19,7 +19,7 @@
// phpcs:enable PSR1.Files.SideEffects

/**
* ComponentDispatcher class for com_privacy
* ComponentDispatcher class for com_users
*
* @since 5.2.3
*/
Expand All @@ -43,7 +43,7 @@ protected function checkAccess()
switch ($view) {
case 'registration':
// If the user is already logged in, redirect to the profile page.
if ($user->get('guest') != 1) {
if ($user->guest != 1) {
// Redirect to profile page.
$this->app->redirect(Route::_('index.php?option=com_users&view=profile', false));
}
Expand All @@ -57,15 +57,15 @@ protected function checkAccess()

// Handle view specific models.
case 'profile':
if ($user->get('guest') == 1) {
if ($user->guest == 1) {
// Redirect to login page.
$this->app->redirect(Route::_('index.php?option=com_users&view=login', false));
}
break;

case 'remind':
case 'reset':
if ($user->get('guest') != 1) {
if ($user->guest != 1) {
// Redirect to profile page.
$this->app->redirect(Route::_('index.php?option=com_users&view=profile', false));
}
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/Model/BackupcodesModel.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/Model/CaptiveModel.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/Model/MethodModel.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/Model/MethodsModel.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/View/Captive/HtmlView.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/View/Method/HtmlView.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
2 changes: 1 addition & 1 deletion components/com_users/src/View/Methods/HtmlView.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* @package Joomla.Administrator
* @package Joomla.Site
* @subpackage com_users
*
* @copyright (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
Expand Down
4 changes: 2 additions & 2 deletions installation/language/af-ZA/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>Afrikaans (Suid-Afrika)</name>
<version>5.2.3</version>
<creationDate>2024-12</creationDate>
<version>5.2.4</version>
<creationDate>2025-01</creationDate>
<author>Afrikaans Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
4 changes: 2 additions & 2 deletions installation/language/ar-AA/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>Arabic (اللغة العربية)</name>
<version>5.2.3</version>
<creationDate>2024-12</creationDate>
<version>5.2.4</version>
<creationDate>2025-01</creationDate>
<author>Dr. Ashraf Damra</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
4 changes: 2 additions & 2 deletions installation/language/be-BY/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>Belarusian (Belarus)</name>
<version>5.2.3</version>
<creationDate>2024-12</creationDate>
<version>5.2.4</version>
<creationDate>2025-01</creationDate>
<author>Joomla Belarus Community</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
4 changes: 2 additions & 2 deletions installation/language/bg-BG/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>Bulgarian (bg-BG)</name>
<version>5.2.3</version>
<creationDate>2024-12</creationDate>
<version>5.2.4</version>
<creationDate>2025-01</creationDate>
<author>Joomla! Bulgaria</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
4 changes: 2 additions & 2 deletions installation/language/ca-ES/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>Catalan (ca-ES)</name>
<version>5.2.3</version>
<creationDate>2024-12</creationDate>
<version>5.2.4</version>
<creationDate>2025-01</creationDate>
<author>Catalan [ca-ES] Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
4 changes: 2 additions & 2 deletions installation/language/cs-CZ/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>Czech (Čeština)</name>
<version>5.2.3</version>
<creationDate>2024-12</creationDate>
<version>5.2.4</version>
<creationDate>2025-01</creationDate>
<author>Czech Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
4 changes: 2 additions & 2 deletions installation/language/cy-GB/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>Welsh (United Kingdom)</name>
<version>5.2.3</version>
<creationDate>2024-12</creationDate>
<version>5.2.4</version>
<creationDate>2025-01</creationDate>
<author>Joomla! Project - Welsh Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
4 changes: 2 additions & 2 deletions installation/language/da-DK/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>Danish (Danmark)</name>
<version>5.2.3</version>
<creationDate>2024-12</creationDate>
<version>5.2.4</version>
<creationDate>2025-01</creationDate>
<author>Danish Translation Team (Transl.: Ronny Buelund)</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
Loading