Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Add removed Input classes to the compat plugin #44925

Open
wants to merge 9 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Feb 17, 2025

Summary of Changes

Reverts #42890 and moves the classes to the compat plugin instead of easier transition. It uses the same logic as #44240 without the option.

Testing Instructions

  • Enable the compat plugin
  • Add the following code to the file /administrator/components/com_content/tmpl/articles/default.php:
    new \Joomla\CMS\Input\Input();
  • Open the back end articles list with at least one article.

Actual result BEFORE applying this Pull Request

A Class "Joomla\CMS\Input\Input" not found exception is thrown.

Expected result AFTER applying this Pull Request

The articles list is loaded.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: Change input chapter to be moved Manual#389

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo changed the title Compat/input [6.0] Add removed Input classes to the compat plugin Feb 17, 2025
@Hackwar
Copy link
Member

Hackwar commented Feb 17, 2025

Why do we have to add back in all those classes, when most of it is a pretty much direct copy of the framework classes? Why can't we use the alias method? I mean, if you insist on adding back in old classes, I can understand to add the CLI class, but the rest is basically just duplicated code. I don't see why we need that.

@laoneo
Copy link
Member Author

laoneo commented Feb 17, 2025

I leave the decision up to the RM's.

@wilsonge
Copy link
Contributor

For the record this one is tricker. Removing the alias from CMSInput functionally changes behavior and forces extensions to change much more of their code as a result. In this very specific case because of that I’m personally against merging this (for the record in favour of merging the other application one)

@laoneo
Copy link
Member Author

laoneo commented Feb 20, 2025

Which alias do you mean? This one? It was added in #43209 after I remove the classes in #42890 and was never in production anyway. So this pr basically restores the 5.x behavior, with the only difference that the classes are moved from libraries to the compat plugin.

@wilsonge
Copy link
Contributor

I do mean that one and even though it's not in production it leads to a much bigger b/c break when the compat plugin is disabled.

@tekvishal
Copy link

getting this error The file marked for modification does not exist: plugins/behaviour/compat/src/classmap/classmap.php


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925.

@tekvishal
Copy link

I have tested this item 🔴 unsuccessfully on 88f0ecd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readd the deprecated app and input classes to the compatibility plugin
5 participants