-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] Add removed Input classes to the compat plugin #44925
base: 6.0-dev
Are you sure you want to change the base?
Conversation
Why do we have to add back in all those classes, when most of it is a pretty much direct copy of the framework classes? Why can't we use the alias method? I mean, if you insist on adding back in old classes, I can understand to add the CLI class, but the rest is basically just duplicated code. I don't see why we need that. |
I leave the decision up to the RM's. |
For the record this one is tricker. Removing the alias from CMSInput functionally changes behavior and forces extensions to change much more of their code as a result. In this very specific case because of that I’m personally against merging this (for the record in favour of merging the other application one) |
I do mean that one and even though it's not in production it leads to a much bigger b/c break when the compat plugin is disabled. |
getting this error The file marked for modification does not exist: plugins/behaviour/compat/src/classmap/classmap.php This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925. |
I have tested this item 🔴 unsuccessfully on 88f0ecd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44925. |
Summary of Changes
Reverts #42890 and moves the classes to the compat plugin instead of easier transition. It uses the same logic as #44240 without the option.
Testing Instructions
new \Joomla\CMS\Input\Input();
Actual result BEFORE applying this Pull Request
A
Class "Joomla\CMS\Input\Input" not found
exception is thrown.Expected result AFTER applying this Pull Request
The articles list is loaded.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Change input chapter to be moved Manual#389
No documentation changes for manual.joomla.org needed