[6.0] Drop Bootstrap::framework

[dgrammatiko]

Pull Request for Issue # .

Summary of Changes

• B/C break
• Drop Bootstrap::framework Since J4 any bootstrap (js) component should be specifically loaded, the framework fn was kept for compatibility

Testing Instructions

• code review
• Add HTMLHelper::_('bootstrap.framework'); somewhere in the index.php of the atum template
• Check that all the BS components are registered

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org: PR

• No documentation changes for manual.joomla.org needed

[HLeithner]

can you please do only on chance in one pr.

• you update package-lock.json (version numer)
• you change code style
• you use deprecated Factory::getDocument()

and the only thing this PR should do is to remove lines 588 to 616 in the Bootstrap.php

[laoneo]

Istead fo removing, I would move it to the compat plugin.

[Hackwar]

Do we have to add the deprecated tag to the methods in the compat plugin as well?

[dgrammatiko]

Do we have to add the deprecated tag to the methods in the compat plugin as well?

To me it feels redundant, as it will never show up in the IDE

[Hackwar]

I agree that it wont show up in the IDE, but it will prevent any discussions in the future about removal and deprecation if you move the tag from the old code also over to the new code.

[Hackwar]

Thank you!

[softforge]

@dgrammatiko I like this change and the addition to the compatibility plugin, to then remove it after.
Can you do as @HLeithner suggested and we can get testing done and merge it

[HLeithner]

the implementation in the b/c plugin is not optimal.

please add a new Class for this function and also an option to disable "all html helper functions" (do we have more?) and make it as option please.

[dgrammatiko]

please add a new Class

what namespace? is namespace Joomla\Plugin\Behaviour\Compat\HTML\Bootstrap ok?

and also an option

simple toggle should be ok here?

@softforge the first batch of requests is already done, I'll do the lest 2 later on (or tomorrow)

[HLeithner]

yes namespace is ok, we already have yes/no fields in the config. something like that

[dgrammatiko]

• toggler added
• moved to own class

[Fedik]

I have tested this item ✅ successfully on 30d3736

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44991.}

[brianteeman]

why not state the version number

[dgrammatiko]

I've tried the not original take here and I copied that part from here:

PLG_COMPAT_XML_DESCRIPTION="If you use extensions which are not using the current Joomla Coding standards then this plugin, when enabled, will provide backward compatibility to the prior major version."

[brianteeman]

to avoid confusion should this not be specific and refer to boostrap html helpers

[dgrammatiko]

Hmm, Harald suggested one switch for all (probably there are more, haven't really checked) of them: #44991 (comment)

[dgrammatiko]

FWIW one or multiple switches is fine by me