-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x][ cypress] null coalescing operator #45008
base: 5.3-dev
Are you sure you want to change the base?
Conversation
Co-authored-by: Tuan Pham Ngoc <[email protected]>
I have tested this item ✅ successfully on bfe4b45 Before applying the patch problem seen:
After aplying this PR with Joomla! Patch Tester the PHP Deprecated message was no more shown. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45008. |
more likely to be a php version thing than an os |
I have tested this item ✅ successfully on bfe4b45 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45008. |
thx for your comment 👍 |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45008. |
@brianteeman Now, I remember JBT disabling deprecated messages as they were caused the tests to fail and there were to many. Perhpas after all the fixes I can hopefully enable checking deprecated again. |
Pull Request for Issue #45006 .
Summary of Changes
null coalescing operator
Testing Instructions
run
npx cypress run --spec '.\tests\System\integration\site\components\com_users\Reset.cy.js'
check php_errors.log
Actual result BEFORE applying this Pull Request
PHP Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated in ..\components\com_users\src\Model\ResetModel.php on line 530: Passing null to parameter #1 ($datetime) of type string is deprecated in ..\components\com_users\src\Model\ResetModel.php on line 530
Expected result AFTER applying this Pull Request
no more
PHP Deprecated: strtotime():
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed