Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x][ cypress] null coalescing operator #45008

Open
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Feb 25, 2025

Pull Request for Issue #45006 .

Summary of Changes

null coalescing operator

Testing Instructions

run npx cypress run --spec '.\tests\System\integration\site\components\com_users\Reset.cy.js'

check php_errors.log

Actual result BEFORE applying this Pull Request

PHP Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated in ..\components\com_users\src\Model\ResetModel.php on line 530: Passing null to parameter #1 ($datetime) of type string is deprecated in ..\components\com_users\src\Model\ResetModel.php on line 530

Expected result AFTER applying this Pull Request

no more PHP Deprecated: strtotime():

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review February 25, 2025 18:30
@alikon alikon changed the title null coalescing operator [5.x][ cypress] null coalescing operator Feb 25, 2025
@alikon alikon mentioned this pull request Feb 25, 2025
@muhme
Copy link
Contributor

muhme commented Mar 1, 2025

I have tested this item ✅ successfully on bfe4b45

Tested on Windows 11 Laragon (as the deprecation message was not reproducable on JBT (using Docker Debian 11) and not reproducable on macOS 15.3.1.

Before applying the patch problem seen:

[01-Mar-2025 16:47:02 UTC] PHP Deprecated:  strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated in C:\laragon\www\j53\components\com_users\src\Model\ResetModel.php on line 530

After aplying this PR with Joomla! Patch Tester the PHP Deprecated message was no more shown.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45008.

@brianteeman
Copy link
Contributor

more likely to be a php version thing than an os

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on bfe4b45

php -v
PHP 8.3.3 (cli) (built: Feb 13 2024 23:17:12) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.3.3, Copyright (c) Zend Technologies


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45008.

@muhme
Copy link
Contributor

muhme commented Mar 1, 2025

more likely to be a php version thing than an os

thx for your comment 👍

it sounds reasonable at first and I wonder as you used 8.3.3, I have 8.1.10 on Windows and JBT is using 8.3.11, I would expect deprecation on the highest PHP version most likely

however the point is to reproduce the problem and then see it gone after the patch 😄

@QuyTon
Copy link
Contributor

QuyTon commented Mar 1, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45008.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 1, 2025
@muhme
Copy link
Contributor

muhme commented Mar 1, 2025

more likely to be a php version thing than an os

@brianteeman Now, I remember JBT disabling deprecated messages as they were caused the tests to fail and there were to many. Perhpas after all the fixes I can hopefully enable checking deprecated again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants