Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Move jquery-noconflict script #45020

Open
wants to merge 5 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • Move jquery-noconflict script to the appropriate folder media/vendor/jquery/js

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Feb 26, 2025
@Fedik
Copy link
Member

Fedik commented Feb 27, 2025

I have tested this item ✅ successfully on ac225bb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on ac225bb

after applying the pr and then npm i I expected to find the jquery-noconflict.js in the media/vendor/jquery folder but it was not there even though thats where media\vendor\joomla.asset.json says it should be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.

@dgrammatiko
Copy link
Contributor Author

@brianteeman thanks, somehow I used .esm.js instead of .es6.js

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on ac225bb

real tests produce real results


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.

@richard67
Copy link
Member

@dgrammatiko Could you fix the linter error reported here? https://ci.joomla.org/joomla/joomla-cms/82752/1/20 Thanks in advance.

@richard67
Copy link
Member

richard67 commented Feb 28, 2025

Restoring @brianteeman 's test result in the issue tracker as the commit which has invalidated the test count was just a linter hint.

@Fedik Could you test again? After your test a relevant change had been made: 64307f0

@Fedik
Copy link
Member

Fedik commented Feb 28, 2025

I have tested this item ✅ successfully on f368dfa

Still looks good to me :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.

@richard67 richard67 changed the title [6.0] Move jquery-noconflict script [6.0] Move jquery-noconflict script Feb 28, 2025
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants