Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Remove redundant entry in the npm tools #45027

Open
wants to merge 3 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • In J5 codemirror was upgraded to v6 with it's own build script but there's an entry in the minification of the vendors pointing to the vendor/codemirror folder. This is redundant

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik

@Fedik
Copy link
Member

Fedik commented Feb 27, 2025

I have tested this item ✅ successfully on f0d9bba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45027.

@Fedik Fedik added the bug label Feb 27, 2025
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on f0d9bba

verified that it does nothing


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45027.

@QuyTon QuyTon removed the bug label Feb 27, 2025
@QuyTon
Copy link
Contributor

QuyTon commented Feb 27, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45027.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 27, 2025
@QuyTon QuyTon added the bug label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR-5.2-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants