Close the apps menu when users click anywhere else in the page #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegbk
approved these changes
Jun 30, 2022
thegbk
requested changes
Jul 26, 2022
| this.$nuxt.$on('routeChanged', () => { | ||
| this.show = false | ||
| }) | ||
| document.addEventListener('click', this.closeMenu) |
There was a problem hiding this comment.
@thread-koder I think using document here is breaking the Vue lifecycle somehow. Can you please her with some resources on how to attach the event listener?
There was a problem hiding this comment.
@alsahawneh Hello I hope you are doing well, this way of handling events definitely breaks the Vue lifecycle, I will attach some resources for event handling in Vue:
Event Handling, explains "Listening to Events", "Event Modifiers" etc...
Component Events, explains "Emitting and Listening to Events", "Declaring Emitted Events", "Events Validation" etc...
Please don't hesitate to tell me if you need any help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57.