Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Room version to 2.7.0-alpha07 #250

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

zsmb13
Copy link
Contributor

@zsmb13 zsmb13 commented Aug 9, 2024

Updated Room to the latest alpha version, which lets us remove some workarounds from the source code as well as from the KSP configuration.

However, because of CMP-5835 the Room plugin can't be applied at the moment.

Repository owner deleted a comment from oreillyjf Sep 6, 2024
@joreilly
Copy link
Owner

joreilly commented Sep 6, 2024

@zsmb13 sounded like this should work now (if I understand https://x.com/zsmb13/status/1831967820160151817 correctly)?

@zsmb13 zsmb13 changed the title WIP: Update Room version to 2.7.0-alpha06 WIP: Update Room version to 2.7.0-alpha07 Sep 6, 2024
@zsmb13 zsmb13 changed the title WIP: Update Room version to 2.7.0-alpha07 Update Room version to 2.7.0-alpha07 Sep 6, 2024
@zsmb13 zsmb13 marked this pull request as ready for review September 6, 2024 12:10
@zsmb13
Copy link
Contributor Author

zsmb13 commented Sep 6, 2024

@joreilly The issue this was stuck on was CMP-5835, which now has a workaround: applying AGP after other plugins (Kotlin, Compose, etc). Added this to the project, with this it should be ready to go.

This strict ordering eventually won't be required when JetBrains/compose-multiplatform#5129 makes it into a release.

@joreilly
Copy link
Owner

joreilly commented Sep 6, 2024

Should 1.json be needed here?

@zsmb13
Copy link
Contributor Author

zsmb13 commented Sep 6, 2024

It's not strictly needed, but in a real project it would be committed to VCS. As the Room schema changes and the database version is updated, it'll generate 2.json etc. Having these files records the history of the schemas over time to help with migrations.

@joreilly joreilly merged commit e5da0d6 into joreilly:main Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants