Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON and YAML struct tags for Status and Error types #17

Merged
merged 1 commit into from
Feb 16, 2019
Merged

JSON and YAML struct tags for Status and Error types #17

merged 1 commit into from
Feb 16, 2019

Conversation

gaborszakacs
Copy link
Contributor

No description provided.

joshdk
joshdk approved these changes Feb 16, 2019
View reviewed changes
Copy link
Owner

@joshdk joshdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @gaborszakacs, looks great!

@joshdk
Copy link
Owner

joshdk commented Feb 16, 2019

I've also filed #18, #19 to call out some related problems with marshalling.

@joshdk joshdk changed the title Lowercase JSON/YAML keys of Test.Status and Error JSON and YAML struct tags for Status and Error types Feb 16, 2019
@joshdk joshdk merged commit 389b262 into joshdk:master Feb 16, 2019
@gaborszakacs gaborszakacs deleted the patch-1 branch February 17, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdk joshdk joshdk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaborszakacs @joshdk