Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace x.ptp() with np.ptp(x) #478

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

joezuntz
Copy link
Contributor

Numpy 2.0 removes the array method .ptp() in favour of the function np.ptp. This replaces the handful of calls in the code.

@segasai
Copy link
Collaborator

segasai commented Jun 24, 2024

Thanks @joezuntz ! I wasn't aware of the .ptp deprecation. I'll merge this after tests run

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9611131905

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 91.657%

Totals Coverage Status
Change from base Build 7180723466: -0.02%
Covered Lines: 4142
Relevant Lines: 4519

💛 - Coveralls

@segasai segasai merged commit af70910 into joshspeagle:master Jun 24, 2024
3 checks passed
@segasai
Copy link
Collaborator

segasai commented Jun 25, 2024

The new version of dynesty on pypi contains this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants