Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merging of runs #482

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Fix merging of runs #482

merged 7 commits into from
Aug 30, 2024

Commits on Aug 29, 2024

  1. refactor the merging to make it clearer what we 

    are doing
    @segasai
    segasai committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    1c785bd View commit details
    Browse the repository at this point in the history

  2. further refactor merging. 

    Now I create a unique batch list. I.e. if one run used
[-inf, inf], [-5,5], [-4,4]
and another
[-inf, inf], [-5,5], [-3,2]
the runs will be [-inf,inf] [-5,5] [-4, 4] [3,2]

I also add a test that test for issue uncovered in #481
    @segasai
    segasai committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    aea5c9c View commit details
    Browse the repository at this point in the history

  3. make the variable names more explicit, as well use more coherent names

    @segasai
    segasai committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    107dc45 View commit details
    Browse the repository at this point in the history

  4. further variable renames to make things clearer

    @segasai
    segasai committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5ba85e8 View commit details
    Browse the repository at this point in the history

  5. rerun the notebook that uses merge a lot

    @segasai
    segasai committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7d831cf View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. add a more extensive test of merge_runs

    @segasai
    segasai committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    dccc1f3 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @segasai
    segasai committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    5feffb1 View commit details
    Browse the repository at this point in the history