Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Add inject option #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add inject option #21

wants to merge 1 commit into from

Conversation

chaffeqa
Copy link

@chaffeqa chaffeqa commented Dec 12, 2017

Supports:

  • false (as documented)
  • "body" (append to body of template)
  • "head" (append to head: default + original)

Supports:
* `false` (as documented)
* 'body' (append to body of template)
* 'head' (append to head: default + original)
@jouni-kantola
Copy link
Owner

Thank you for the PR 🥇

A couple of comments:

  1. The inject option you're referring to as documented is actually for html-webpack-plugin.

After we decide if we should add this option or not, then I'd appreciate tests and docs for it.

  1. Tests fits around here: https://github.com/jouni-kantola/inline-chunk-manifest-html-webpack-plugin/blob/master/test/plugin-inject-manifest-test.js#L4

  2. The last bit that I think is missing is docs for the new configuration property. It probably needs extra clarity in this case, since there already is a similar configuration option for html-webpack-plugin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants