✨ Deal with sparse arrays

journy-io · Apr 5, 2021 · e8b4641 · e8b4641
1 parent 954bc27
commit e8b4641
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 1 deletion.
diff --git a/src/Client.php b/src/Client.php
@@ -505,7 +505,7 @@ function (array $user) {
                         ),
                     ];
                 },
-                $account["members"]
+                array_values($account["members"])
             );
         }
 

diff --git a/tests/ClientTest.php b/tests/ClientTest.php
@@ -334,6 +334,51 @@ public function test_it_upserts_account_without_account_id()
         }
     }
 
+    public function test_it_deals_with_sparse_arrays()
+    {
+        $factory = new Psr17Factory();
+        $json = '{"message":"The data is correctly stored.","meta":{"status":201,"requestId":"01ETG3HQ4JY4HNNZ84FBJM3CSC"}}';
+        $http = new HttpClientFixed(new Response(201, [], $json));
+        $client = new Client($http, $factory, $factory, ["apiKey" => "key"]);
+        $now = new DateTimeImmutable("now");
+
+        $this->assertEquals(
+            new CallResult(true, false, 0, 0, [], null),
+            $client->upsertAccount(
+                [
+                    "accountId" => "1",
+                    "members" => [
+                        1 => ["userId" => "1"],
+                        2 => ["userId" => "2"],
+                    ],
+                ]
+            )
+        );
+
+        $request = $http->getLastRequest();
+        $this->assertInstanceOf(RequestInterface::class, $request);
+        if ($request instanceof RequestInterface) {
+            $request->getBody()->rewind();
+            $body = $request->getBody()->getContents();
+            $payload = json_decode($body, true);
+            $this->assertEquals(
+                [
+                    "identification" => [
+                        "accountId" => "1",
+                    ],
+                    "members" => [
+                        [
+                            "identification" => ["userId" => "1"],
+                        ],
+                        [
+                            "identification" => ["userId" => "2"],
+                        ],
+                    ],
+                ],
+                $payload
+            );
+        }
+    }
 
     public function test_it_triggers_event_for_user()
     {