Merge pull request #895 from joyent/ether/v2-response-header-version

add a X-Conch-API header to every response
joyent · Sep 26, 2019 · 572409e · 572409e
2 parents 112c428 + 26f03da
commit 572409e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/Conch.pm b/lib/Conch.pm
@@ -60,6 +60,9 @@ sub startup {
         }
     );
 
+    $self->hook(after_render => sub ($c, @args) {
+        $c->tx->res->headers->add('X-Conch-API', $c->version_tag);
+    });
 
     $self->helper(
         status => sub ($c, $code, $payload = undef) {

diff --git a/t/integration/crud/unsecured-endpoints.t b/t/integration/crud/unsecured-endpoints.t
@@ -11,7 +11,8 @@ $t->load_fixture('legacy_datacenter');
 
 $t->get_ok('/ping')
     ->status_is(200)
-    ->json_is({ status => 'ok' });
+    ->json_is({ status => 'ok' })
+    ->header_is('X-Conch-API', $t->app->version_tag);
 
 $t->get_ok('/version')
     ->status_is(200)