Merge pull request #854 from joyent/ether/v2-collapse-validation_resu…

…lt-fix go through pages in reverse
joyent · Aug 8, 2019 · 85b727c · 85b727c
2 parents 8521644 + 8b40a80
commit 85b727c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/Conch/Command/merge_validation_results.pm b/lib/Conch/Command/merge_validation_results.pm
@@ -119,7 +119,9 @@ sub _process_device ($self, $device) {
         ->page(1)
         ->hri;
 
-    foreach my $page (1 .. $groups_to_merge_rs->pager->last_page) {
+    # we go through the pages backward so we can delete rows as we go and not
+    # break queries for the other pages.
+    foreach my $page (reverse(1 .. $groups_to_merge_rs->pager->last_page)) {
         $groups_to_merge_rs = $groups_to_merge_rs->page($page);
 
         # foreach matching set,