Merge pull request #851 from joyent/ether/fix-slow-validation_result-…

…inserts

v2: fix slow validation result inserts

lib/Conch/ValidationSystem.pm

@@ -356,7 +356,7 @@ sub run_validation_plan ($self, %options) {
             $validator->validation_results;
 
         $self->log->debug('validation '.$validation->name.' returned no results for device id '.$device->id)
-            if not @validation_results;
+            if not $validator->validation_results;
     }
 
     # maybe no validations ran? this is a problem.

sql/migrations/0092-validation_result-index.sql

@@ -0,0 +1,9 @@
+SELECT run_migration(92, $$
+
+    -- this is used when inserting validation_state + validation_state_member +
+    -- validation_result records at the end of running a validation_plan and we seek
+    -- to re-use old records where possible instead of creating a new ones
+    create index validation_result_all_columns_idx on validation_result
+        (device_id, hardware_product_id, validation_id, message, hint, status, category, component_id, result_order);
+
+$$);

sql/schema.sql

@@ -1378,6 +1378,13 @@ CREATE INDEX validation_plan_member_validation_plan_id_idx ON public.validation_
 CREATE UNIQUE INDEX validation_plan_name_idx ON public.validation_plan USING btree (name) WHERE (deactivated IS NULL);
 
 
+--
+-- Name: validation_result_all_columns_idx; Type: INDEX; Schema: public; Owner: conch
+--
+
+CREATE INDEX validation_result_all_columns_idx ON public.validation_result USING btree (device_id, hardware_product_id, validation_id, message, hint, status, category, component_id, result_order);
+
+
 --
 -- Name: validation_result_device_id_idx; Type: INDEX; Schema: public; Owner: conch
 --