Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Releases: joyent/conch-api

v3.0.0-a8

21 Oct 22:03
@karenetheridge karenetheridge
v3.0.0-a8
d0dc7f2
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Compare
Choose a tag to compare
v3.0.0-a8 Pre-release
Pre-release

Release v3.0.0-a8

PR #917 - v3: a8 fixes

  • Branch: ether/v3-a8-fixes
  • Revision: 222dcf5
  • Labels: api, bug
  • when creating a device via POST /rack/:id/assignment, put the device in the rack's build
  • fix embarrassing typos in request json schema

People

Commits

  • 31a3e6 - inherit build from rack when creating device in a rack assignment
  • b680d6 - fix embarrassing typos in json schemas

PR #919 - v3: a8 doc fixes

  • Branch: ether/v3-a8-doc-fixes
  • Revision: 2b10460
  • Labels: docs

some fixes to some small doc errors, and added some database schema diagrams.

People

Commits

  • 44adec - create an images dir
  • 90bd75 - some schema diagrams
  • 482b56 - a bit more general documentation
  • 2be07e - include schema diagrams in main doc page
  • 8a5083 - key is a placeholder
  • 55b7be - improve Conch::Time docs
  • b200ae - fix incomplete migration of /schema endpoint docs
  • 4303ed - fix bad link

PR #920 - v3-a8: more fixes

  • Branch: ether/v3-a8-more-fixes
  • Revision: e7d2aff
  • Labels: api, bug
  • fix some request header handling for the "send message to rollbar when an error happens" feature
  • dispatch log message was losing a few fields if a rollbar message was sent
  • change to build logic: no longer allow setting a build to completed if it has devices that are not passing validations
  • change to build logic: allow adding a device to a build when it is located in a rack that is in another build

People

Commits

  • 6bbd8f - fix shebang
  • 6dcb7b - typo in instruction
  • edcea2 - curl doesn't like ~, so do shell expansion first
  • d31f4e - verify that client verification header matches are case-insensitive
  • 4e2494 - rewrite rollbar "error_match_header" logic for header case-insensitivity
  • 44270a - do not mutate dispatch log payload when sending rollbar message
  • 832b60 - fix: disallow build completion in the future
  • 4fecab - fix: allow adding a device to a build when its rack is in another build
  • b0282e - use a more sensible check here
  • e6d09c - do not allow completing a build if it has unhealthy devices
  • ce748c - do not attempt to jsonify an undef

PR #921 - scripts for v3 launch activities

  • Branch: ether/v3-launch-scripts
  • Revision: d0dc7f2
  • Labels: high priority, v3

These should be run just once.

People

Commits

  • 3e7b99 - script for fixing old Joyent user entries
  • e91c57 - script for creating build entries based on historical workspaces
Assets 2
Loading

v2.36.2

15 Oct 19:21
@karenetheridge karenetheridge
v2.36.2
9c4ca68
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Compare
Choose a tag to compare
v2.36.2

Release v2.36.2

PR #918 - v2: request schema typos

  • Branch: ether/v2-request-schema-typos
  • Revision: 9c4ca68
  • Labels: api, bug

This was causing invalid fields to slip through and then cause explosions when they reached the database

as done in v3 (PR #917).

People

Commits

  • 26a05b - fix embarrassing typos in json schemas
Assets 2
Loading

v3.0.0-a7

14 Oct 22:49
@karenetheridge karenetheridge
v3.0.0-a7
6d8d916
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Compare
Choose a tag to compare
v3.0.0-a7 Pre-release
Pre-release

Release v3.0.0-a7

PR #902 - backfill some validation_results to ensure uniqueness

  • Branch: ether/v3-fix-validation_result-uniqueness
  • Revision: 2d22986
  • Labels: bug, database, validation

...otherwise merge_validation_results will experience unique constraint
violatiosn when collapsing multiple validation_result rows together in the
same validation_state, because CpuTemperature and SwitchPeers did not store
sufficient unique data in their results.

These new update queries should be run manually on existing conch-v3 systems
before running merge_validation_results; otherwise (on v2->v3 migrations) the
update will happen at the right time, even though it will make this migration
run even longer than before (18+hrs on edge)

this should fix #901.

People

Commits

  • c16ec4 - backfill some validation_results to ensure uniqueness

PR #903 - v3: associate hardware_product with validation_plan

  • Branch: ether/v3-hardware_product-validation_plan
  • Revision: 018b49b
  • Labels: breaking, database, device reports, enhancement, needs-shell, v3, validation
  1. look up validation plan by hardware_product, rather than hacky hardcoded heuristic
  • add validation_plan_id to hardware_product, using historical validation data to
    populate existing rows
  • this means that we can no longer deactivate validation plans and create new
    ones with the same name, and expect them to be used in place of their former
    version. we need to either update plans in place, or update references to the
    plan (i.e. hardware_product.validation_plan_id).
  1. no longer use the rack_layout's hardware_product in validations, but the device's
    At least for now, some parameters used in validations are stored in the
    hardware_product and hardware_product_profile, and these should be consistent
    with the report's sku.

closes #806 (see also #807).

People

Commits

  • e5f130 - shorten these calls by using unserialized data
  • 7cfb3c - move these tests up to avoid concocting test data twice
  • 6e74d4 - test for hardware product mismatch in validate_report path too
  • 298f84 - look up validation plan by hardware_product, rather than hacky hardcoded heuristic
  • 0511e7 - include the validation version when logging an issue with it
  • 644a61 - no longer use the rack_layout's hardware_product in validations, but the device's

PR #905 - fix send-email documentation and negation

  • Branch: send-email-fixes
  • Revision: 2a6f1f6
  • Labels:

The help for send-email says the flag is named --send-mail but that isn't correct.

Also the option defaulted to true with no way to negate it, so I added a modifier to tell GetOpt::Long::Descriptive to allow --no-send-email as well.

People

Commits

  • 466351 - fix send-email documentation and negation

PR #906 - fix: log the same response that we are returning

  • Branch: ether/v3-txn_wrapper
  • Revision: fd4df62
  • Labels: bug, device reports

This discrepancy occurred in places where $c->status(..) or $c->rendered(..)
was called more than once in a dispatch cycle. The after_dispatch hook is only
called once, for the first call, but what is returned in the response reflects
the last call.

  • refactor the txn_wrapper helper to not actually render a response, but just
    use the return value to signal the outcome; the inclusion of the first line of
    the exception in the response has moved to the status helper

  • also added a check in the after_render hook to ensure this does not happen again.

People

Commits

  • b26125 - fix: log the same response that we are returning

PR #908 - v3: a7 misc cleanup

  • Branch: ether/v3-a7-misc-cleanup
  • Revision: 72ab618
  • Labels: docs, tests

Small fixes to tests, documentation etc that do not change any runtime functionality.

People

Commits

  • 4658b9 - be more consistent with dumping data in tests
  • 92ee50 - avoid repetition
  • 687bf4 - show the log entries when log tests fail
  • 6250ea - better documentation for helper methods
  • a55bd4 - use just one variable to store the hardware product
  • d98f43 - make sure documentation rendering issues are visible
  • 4a3d1a - improve status_is check
  • b10ae5 - fix docs for this command
  • 6c8976 - remove bug link that is no longer needed

PR #909 - v3: a7 better checks

  • Branch: ether/v3-a7-better-checks
  • Revision: 7a6b93b
  • Labels: bug, database
  • new database constraints for the build table, to reflect application logic
  • new database indexes for foreign keys on recently-added tables (and removed some redundant ones)
  • strengthen email address validation and make it consistent across the application

People

Commits

  • 23c04f - database constraints for build columns
  • 071d2a - add some missing indexes for organizations and builds
  • 657efe - this hook should be deleting the template on transformation
  • 4f1225 - merge inconsistent email format checks, in create_user command too

PR #910 - v3: endpoint proxy caching

  • Branch: ether/v3-endpoint-proxy-caching
  • Revision: 21ca82b
  • Labels: api, enhancement, needs-buildops_infra, v3

Adds basic caching support for some endpoints:

  • GET /version and GET /schema/* endpoint responses include a Last-Modified header (and check If-Modified-Since to allow for nginx to cache these responses)
  • GET /device/:id_or_serial responses include an ETag header (and check If-None-Match to allow for repeated polling while waiting for updates from reports -- see joyent/conch-ui#146 and https://github.com/joyent/buildops-infra/issues/103)

People

Commits

  • 7ce408 - include a Last-Modified header with GET /version
  • be7989 - allow for caching of GET /schema/* data by checking If-Modified-Since
  • 13467b - allow caching of GET /device/:id with If-None-Match and ETag

PR #911 - v3: resource access fixes

  • Branch: ether/v3-user_has_role
  • Revision: 5a55cd5
  • Labels: bug, v3

fix: permission checks for unlocated devices in a build

It used to be that we could only do a specific role check for devices that had
a location, but now...

Read more
Assets 2
Loading

v2.36.1

14 Oct 22:11
@karenetheridge karenetheridge
v2.36.1
222d14d
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Compare
Choose a tag to compare
v2.36.1

Release v2.36.1

PR #916 - ensure a validation module is loaded before trying to run it

  • Branch: ether/v2-load-validation
  • Revision: 222d14d
  • Labels: validation

People

Commits

  • 0bbce3 - ensure a validation module is loaded before trying to run it
Assets 2
Loading

v2.36.0

08 Oct 16:12
@karenetheridge karenetheridge
v2.36.0
d1dc217
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Compare
Choose a tag to compare
v2.36.0 Pre-release
Pre-release

Release v2.36.0

PR #907 - fix: log the same response that we are returning

  • Branch: ether/v2-txn_wrapper
  • Revision: d1dc217
  • Labels: bug, device reports

This discrepancy occurred in places where $c->status(..) or $c->rendered(..)
was called more than once in a dispatch cycle. The after_dispatch hook is only
called once, for the first call, but what is returned in the response reflects
the last call.

  • refactor the txn_wrapper helper to not actually render a response, but just
    use the return value to signal the outcome; the inclusion of the first line of
    the exception in the response has moved to the status helper. Caught
    exceptions are now included in the dispatch log.

  • also added a check in the after_render hook to ensure this does not happen again.

As done for v3 in #906.

People

Commits

  • 51b712 - fix: log the same response that we are returning
Assets 2
Loading

v3.0.0-a6

02 Oct 17:11
@karenetheridge karenetheridge
v3.0.0-a6
546d5e1
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Compare
Choose a tag to compare
v3.0.0-a6 Pre-release
Pre-release

Release v3.0.0-a6

PR #882 - v3: moar docs!

  • Branch: ether/v3-moar-docs
  • Revision: 0e60dee
  • Labels: api, docs
  • make json schemas available in Github Pages documentation
  • link to json schemas from endpont documentation
  • more general endpoint docs
  • document methods from external plugins pulled into database classes

People

Commits

  • dba521 - document the methods added to results and resultsets
  • 3c679b - add link back to main page from subindexes
  • 1762a5 - add YAML marker and vim modelines to json schemas
  • f353d7 - autogenerate json schemas as .json in docs/
  • ce2261 - use comments that will show up in the json conversion
  • 0fb6c5 - Add more top-level route documentation; make json schema references link to the json doc files

PR #883 - v3: even moar docs

  • Branch: ether/v3-even-moar-docs
  • Revision: fa0dd8f
  • Labels: docs

document bin/conch-db and bin/conch a bit more

People

Commits

  • a30ad5 - add more docs in bin/conch-db
  • a8fe22 - add list of conch commands to markdown doc

PR #884 - v3: still moar docs

  • Branch: ether/v3-still-moar-docs
  • Revision: 07711bf
  • Labels: docs

People

Commits

  • 76a209 - doc amendment
  • 4a4cb5 - typo!
  • 437c5a - do not use perl syntax highlighting for bare text blocks
  • e7b911 - allow processing one json-schema file on its own
  • 0e9287 - ignore vim swap files

PR #885 - v3: more validation_result improvements

  • Branch: ether/v3-collapse-validation_result-more
  • Revision: 49826ec
  • Labels: breaking, database, needs-shell, needs-ui, v3

Move result_order from the validation_result table to validation_state_member, which allows even more re-use of validation_result rows.

After deploying this migration, you should re-run bin/conch merge_validation_results and we should see another 10x reduction in rows in the validation_result table. After that is done, it should be possible to make validation_result_all_columns_idx a unique index.

Minor adjustments are also made to response payloads that include validation results.

People

Commits

  • 2e9ff3 - move result_order to validation_state_result and drop it from response payloads
  • f393ce - cascade deletes from validation_result -> validation_state_member
  • 069b0c - sort the validation results in this response too

PR #888 - v3: a6 misc cleanup

  • Branch: ether/v3-a6-misc-cleanup
  • Revision: 2198633
  • Labels: docs, tests

No changes to functionality here.

  • some additional tests and tightening existing ones
  • small documentation fixes
  • speed up some type checks by including the XS implementation.
  • removed some unused libraries from the dependency list.

People

Commits

  • ea2c1e - remove these no-longer-used methods
  • 7e40d6 - remove unused dependencies
  • 6952a0 - speed up Type::Tiny
  • e31391 - 305 responses also contain a Location header
  • 9e4936 - also test that 30x responses do not have body content
  • 2cadbc - ensure all redirect responses test the Location header
  • ab455f - clear log a few more times to be sure
  • 2bf62c - add a note about the limitations of this file
  • 5ef7f9 - clearly mark these directories as not for human editing
  • a7ac31 - fix bad wording
  • d45a7b - tighten up these regex tests
  • 2aa904 - remove some unneeded sigil wrapping
  • 640a40 - rename this variable for clarity
  • aba7da - more tests for role checks
  • 8a8b4f - clean up fixture handling for definitions needing []

PR #889 - v3: a6 small refactoring

  • Branch: ether/v3-a6-small-refactoring
  • Revision: 057a763
  • Labels: api, enhancement, refactor

Some small refactoring and functionality improvements:

  • refactored the route flow for the workspace-rack endpoint
  • command line helper script for fetching an api token
  • when logging requests, do not redact sensitive headers entirely from the log, but just their contents (e.g. to verify that a certain header was indeed present)
  • raise minimum requires postgres version to 10.10
  • log something when an organization role check fails
  • allow removing oneself from an organization
  • cache the contextual logger across the entire request
  • bail out earlier on erroneous input in a few places (bad log level in config file; unrecognized subcommand passed to conch-db)

People

Commits

  • f833b8 - add another action to the chain to detect if workspace-rack relation does not exist
  • 456ca7 - new script for getting a new api token
  • adad94 - keep sensitive headers in logs; just redact the contents
  • 834e03 - postgres 10.10 is out; it is our new minimum
  • dddda3 - this count is already known to be > 0
  • 267f95 - log something when an organization role check fails
  • bfab32 - allow removing oneself from an organization
  • df7fe9 - bail out on unrecognized command
  • 997b36 - reject bad log levels
  • d7c5d0 - cache the context-sensitive logger in the stash

PR #890 - v3: builds

  • Branch: ether/v3-builds
  • Revision: d6fdb56
  • Labels: api, breaking, needs-shell, needs-ui, v3
  • New endpoints:
    • GET /build/:build_id_or_name
    • POST /build/:build_id_or_name
    • GET /build/:build_id_or_name/user
    • POST /build/:build_id_or_name/user?send_mail=<1|0>
      ...
Read more
Assets 2
Loading

v2.35.0

26 Sep 17:14
@karenetheridge karenetheridge
v2.35.0
572409e
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Compare
Choose a tag to compare
v2.35.0

Release v2.35.0

PR #895 - add a X-Conch-API header to every response

  • Branch: ether/v2-response-header-version
  • Revision: 572409e
  • Labels: api, bug, needs-shell, needs-ui

This way, clients can check the version even when their client is not
compatible with the api.

People

Commits

  • 26f03d - add a X-Conch-API header to every response
Assets 2
Loading

v2.34.0

17 Sep 17:12
@karenetheridge karenetheridge
v2.34.0
112c428
Compare
Choose a tag to compare
v2.34.0

Release v2.34.0

PR #873 - add DELETE /relay/:serial

  • Branch: ether/v2-relay-delete
  • Revision: 25d75d6
  • Labels: api, enhancement, needs-shell

closes #868.
(backported from #872 in v3.)

People

Commits

  • a56268 - add DELETE /relay/:serial
Assets 2
Loading

v3.0.0-a5

10 Sep 23:42
@karenetheridge karenetheridge
v3.0.0-a5
8908c4a
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Compare
Choose a tag to compare
v3.0.0-a5 Pre-release
Pre-release

Release v3.0.0-a5

PR #864 - stop running migrations if one failed

  • Branch: ether/migration-bailout
  • Revision: 06027ce
  • Labels: bug, database

People

Commits

  • a4308f - stop running migrations if one failed

PR #865 - v3: fix role checking on these endpoints with atypical role requirements

  • Branch: ether/v3-role-fixes-part3
  • Revision: ac50f88
  • Labels: api, bug

POST /device/:device_id_or_serial_number/validation/:validation_id
POST /device/:device_id_or_serial_number/validation_plan/:validation_plan_id
POST /workspace/:workspace_id_or_name/rack

People

Commits

  • c6ef67 - fix role checking on these endpoints with atypical role requirements

PR #866 - v3: migration fixes

  • Branch: ether/v3-migration-fixes
  • Revision: 9108f11
  • Labels: bug, database

fixes migrations 100 and 125.

People

Commits

  • 73aa81 - fix this migration to only delete rows for sysadmin users
  • 219c4b - rewrite this migration so it only runs once, as expected

PR #872 - add DELETE /relay/:id_or_serial

  • Branch: ether/relay-delete
  • Revision: 0cbfca5
  • Labels: api, enhancement, needs-shell

closes #868.

People

Commits

  • e10cba - add DELETE /relay/:id_or_serial

PR #874 - add relay.last_seen

  • Branch: ether/v3-relay-last_seen
  • Revision: f5f3ca5
  • Labels: api, database, enhancement, needs-shell

..and update it when we update user_relay_connection or device_relay_connection.
closes #869.

People

Commits

  • acae0f - streamline this query a bit
  • 54ce4c - add relay.last_seen

PR #875 - make device_setting and user_setting consistent: no nulls, strings only

  • Branch: ether/v3-device-user-settings
  • Revision: 78a5a81
  • Labels: api, breaking, database, needs-shell

People

Commits

  • 71d1d2 - make device_setting and user_setting consistent: no nulls, strings only

PR #876 - better queries, most notably involving workspaces

  • Branch: ether/v3-better-workspace-queries
  • Revision: 16671ae
  • Labels: refactor, tests
  • optimizations to how some queries are constructed, that do not affect the outcome
  • refactoring of some db query construction routines
  • new script to verify the integrity of all existing workspace_rack relationships
  • additional test coverage of various database relationships, especially pertaining to permission checks
  • eliminate needless recursive workspace searches involving racks, which should speed up some device-related endpoints significantly

People

Commits

  • 524065 - shorten these query constructs
  • e9cd88 - eliminate needless subselects
  • 623c6f - eliminate a db query when fetching device settings
  • d759bb - save a query by using a subselect
  • e5ea9d - new script to verify the integrity of all workspace-rack relationships
  • 36f0fe - remove duplicate code by chaining to rack resultset method
  • 1f4dfd - move user_has_role from user_workspace_role to workspace
  • 85ba78 - new, more generic method workspace_rs->with_user_role
  • 6ccadd - eliminate needless recursive workspace searches involving racks
  • becd73 - remove unnecessary table join
  • 4c212b - make these queries more efficient
  • 85d478 - proper tests of direct and indirect workspace access, through racks and devices
  • acea77 - speed up queries by using UNION ALL
  • 773a32 - simplify query when role = 'ro'

PR #879 - device report optimization

  • Branch: ether/v3-device_report-optimization
  • Revision: c39475d
  • Labels: database, device reports

adjustments to prior sql migrations:

  • while dropping device_report.invalid_report, drop all rows with this field set (as nothing else of value is contained in this record)
  • device_report.report can now be made not-nullable

People

Commits

  • fda768 - also delete reports with invalid reports in them
  • 0c5f75 - device_report.report can now be made mandatory

PR #878 - new endpoint for (re)defining a rack of layouts at once

  • Branch: ether/v3-overwrite-rack_layout
  • Revision: 044a3a6
  • Labels: api, enhancement

that is, POST /rack/:rack_id/layouts

closes #877.

People

Commits

  • ee39a5 - rename this endpoint sub
  • 59d7ff - new endpoint for (re)defining a rack of layouts at once

PR #862 - v3: organizations!

  • Branch: ether/v3-organizations
  • Revision: 97cfe09
  • Labels: api, breaking, database, enhancement, needs-shell, needs-ui, v3

closes #826.

People

Commits

  • 3e3f07 - organizations are born -- autogenerated files only
  • f3f081 - add /organization endpoints
  • ef519a - make workspaces and organizations aware of each other
  • 449e1a - separate local helpers into ResultSet, Row namespaces
  • 9b8dba - add organizations to UserDetailed
  • 4d6b31 - rename user_workspace_role_enum to role_enum
  • 1553f9 - add regex testing for log lines
  • cba78a - add workspaces reachable by orgs to UserDetailed

PR #881 - hub.docker is no longer supported

  • Branch: sungo/hub-docker-removal
  • Revisio...
Read more
Assets 2
Loading

v3.0.0-a4

13 Aug 16:25
@sungo sungo
v3.0.0-a4
6e26b93
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Compare
Choose a tag to compare
v3.0.0-a4 Pre-release
Pre-release

Release v3.0.0-a4

PR #843 - v3: more small fixes part3

  • Branch: ether/v3-more-small-fixes-part3
  • Revision: 94b9b99
  • Labels: api, breaking, needs-shell, needs-ui
  • small tweaks to json schema names and field names
  • internal optimizations

People

Commits

  • 9f7232 - skip checks that are redundant with signatures
  • f52d79 - use a more unique request_id
  • 5ef0fb - speed up queries by skipping sanity check in production deployments
  • 5d29aa - json schemas: use a reference here
  • 85aab5 - remove no-longer-used json schema
  • ba7ec6 - json schemas: normalize "rack_role_name"
  • 933f2f - tighten up a bit of serialization code
  • bf58b3 - json schemas: rename this schema to be more generic
  • 484967 - log an error when no matching route is found for a URL
  • ff16ef - repair this migration
  • ed9282 - fix: hdd_size validation when specification is unset
  • deda40 - keep $message defined by parsing it properly
  • fc6674 - fix docs for accuracy
  • 76a8a5 - fix doc markup
  • 3a5e1c - include the conch_read_only role in the schema dump and db initialization

PR #849 - v3: role fixes

  • Branch: ether/v3-role-fixes
  • Revision: 6f36d87
  • Labels: api, bug, docs, tests, v3, wat

Many fixes pertaining to role checks all through the system.

  • cleaned up documentation wording
  • fix: /workspace/:id/user endpoints now all require the workspace "admin" role
  • mail workspace admins when user membership changes
  • "submit device data for validation testing" endpoints now only require "ro"
  • fix: filter GET /device?:key=:value results for what the user is permitted to see
  • fix: non-admin users can now change device settings on unlocated devices
  • fix: require user to be a system admin for DELETE /rack/:rack_id
  • fix: require user to be a system admin for DELETE /hardware_vendor/:id_or_name
  • fix: allow everyone to use GET /rack_role and GET /rack_role/:id (closes #834)

People

Commits

  • d70485 - make it easier to send (and test sending) multiple emails at once
  • d349fa - fix: /workspace/:id/user endpoints now all require the workspace "admin" role
  • bc947f - docs etc: use consistent language everywhere re "roles"
  • ba83f5 - mail workspace admins when user membership changes
  • b470e4 - test cleanup: move more tests to where they belong, and add some more role tests
  • 346a3a - fix: role change for "submit device data for validation testing" endpoints
  • 0f3b28 - fix: filter GET /device?:key=:value results for what the user is permitted to see
  • 970ecb - fix: non-admin users can now change device settings on unlocated devices
  • 23ba7d - fix: require user to be a system admin for DELETE /rack/:rack_id
  • e7899e - fix: require user to be a system admin for DELETE /hardware_vendor/:id_or_name
  • 2765ca - fix: allow everyone to use GET /rack_role and GET /rack_role/:id
  • 4405e1 - add some more and better tests

PR #852 - v3: role fixes part2

  • Branch: ether/v3-role-fixes-part2
  • Revision: 17bef6d
  • Labels: api, breaking, bug, v3

More fixes for role checks all over the system.

  • always allow sysadmin users when doing rack auth checks
  • log when a role check fails
  • let users with the "rw" role create a subworkspace (and they are given the "admin" role on it, if they did not have it already through some other means)
  • fix conflation of superusers and workspace-admin users everywhere (side effect: "role_via" fields will no longer appear for results regarding system admin users)
  • fix: do not show parent_workspace_ids to users who cannot access them

People

Commits

  • 4310a5 - always allow sysadmin users when doing rack auth checks
  • 8727c2 - centralize system admin checks in route generation
  • ade02d - log when a role check fails
  • 85c3d0 - let users with the "rw" role create a subworkspace
  • 9ba42f - avoid duplicate entries in GET /workspace/:id/user responses
  • 2d0090 - clean up messages on failure in POST /workspace/:id/user
  • 9457fa - fix conflation of superusers and workspace-admin users
  • 67c227 - remove unneeded use of constants here
  • c8c48c - remove unnecessary periods in email subjects
  • edd10e - fix: do not show parent_workspace_ids to users who cannot access them
  • 2d0492 - also send mail when creating a subworkspace
  • dc168c - fix this test username so it sorts better with upcoming data

PR #859 - compare semver versions properly

  • Branch: ether/fix-postgres-version
  • Revision: c169fe8
  • Labels: bug, database, tests

also fix undef value where 10.x does not have a third version component
and check the version in tests also, with a visible diagnostic line.

People

Commits

  • 1c2724 - compare semver versions properly

PR #860 - v3: more doc fixes

  • Branch: ether/v3-more-doc-fixes
  • Revision: 4e71bec
  • Labels: docs

misc fixes to doc generation, and add pages for executables.

People

Commits

  • 82b081 - also generate docs for bin/*, and create a new index page for them
  • f811e6 - fix bad local links
  • 389fee - add copyright footer to newly-generated db classes
  • [a56e88](https://git...
Read more
Assets 2
Loading