Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various minor bugs detected by static analyzer #579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix various minor bugs detected by static analyzer #579

wants to merge 1 commit into from

Conversation

TysonAndre
Copy link

  • saw a no-op array statement in Validations class,
    assume $enum = [$enum] was intended.
  • PDO wasn't namespaced in lib/adapters/OciAdapter,
    so it referred to ActiveRecord\PDOException
  • Incorrect phpdoc in callback for $model

@TysonAndre-tmg
Fix various minor bugs detected by static analyzer
094dfd9 
- saw a no-op array statement in Validations class,
  assume `$enum = [$enum]` was intended.
- PDO wasn't namespaced in lib/adapters/OciAdapter,
  so it referred to `ActiveRecord\PDOException`
- Incorrect phpdoc in callback for $model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TysonAndre @TysonAndre-tmg