Skip to content

Commit

Permalink
Deprecate tokens
Browse files Browse the repository at this point in the history
  • Loading branch information
joshwooding committed Feb 14, 2025
1 parent 2fa4c1d commit 5120332
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/beige-horses-poke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@salt-ds/theme": minor
---

Deprecated `--salt-palette-navigate-foreground-hover` and `--salt-palette-navigate-foreground-active` and replaced them with `--salt-palette-accent-foreground-informative`.
4 changes: 2 additions & 2 deletions packages/theme/css/characteristics/content.css
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
--salt-content-bold-foreground: var(--salt-palette-interact-cta-foreground);
--salt-content-bold-foreground-disabled: var(--salt-palette-interact-cta-foreground-disabled);

--salt-content-foreground-hover: var(--salt-palette-navigate-foreground-hover);
--salt-content-foreground-active: var(--salt-palette-navigate-foreground-active);
--salt-content-foreground-hover: var(--salt-palette-accent-foreground-informative);
--salt-content-foreground-active: var(--salt-palette-accent-foreground-informative);
--salt-content-foreground-visited: var(--salt-palette-navigate-foreground-visited);
--salt-content-foreground-highlight: var(--salt-palette-interact-background-active);
}
4 changes: 4 additions & 0 deletions packages/theme/css/deprecated/palette.css
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@
--salt-palette-navigate-tertiary-background-hover: var(--salt-color-gray-20);
--salt-palette-navigate-indicator-activeDisabled: var(--salt-color-orange-600-fade-border);
--salt-palette-navigate-background-hover: var(--salt-color-black-fade-background-hover);
--salt-palette-navigate-foreground-hover: var(--salt-color-blue-600);
--salt-palette-navigate-foreground-active: var(--salt-color-blue-700);

/* Track */
--salt-palette-track-border: var(--salt-color-gray-90);
Expand Down Expand Up @@ -188,6 +190,8 @@
--salt-palette-navigate-tertiary-background-hover: var(--salt-color-gray-700);
--salt-palette-navigate-indicator-activeDisabled: var(--salt-color-orange-400-fade-border);
--salt-palette-navigate-background-hover: var(--salt-color-white-fade-background-hover);
--salt-palette-navigate-foreground-hover: var(--salt-color-blue-200);
--salt-palette-navigate-foreground-active: var(--salt-color-blue-300);

/* Track */
--salt-palette-track-border: var(--salt-color-gray-90);
Expand Down
4 changes: 0 additions & 4 deletions packages/theme/css/palette/navigate.css
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
.salt-theme[data-mode="light"] {
--salt-palette-navigate-foreground-hover: var(--salt-color-blue-600);
--salt-palette-navigate-foreground-active: var(--salt-color-blue-700);
--salt-palette-navigate-foreground-visited: var(--salt-color-purple-800);
--salt-palette-navigate-indicator-hover: var(--salt-color-gray-90);
--salt-palette-navigate-indicator-active: var(--salt-color-orange-600);
}

.salt-theme[data-mode="dark"] {
--salt-palette-navigate-foreground-hover: var(--salt-color-blue-200);
--salt-palette-navigate-foreground-active: var(--salt-color-blue-300);
--salt-palette-navigate-foreground-visited: var(--salt-color-purple-100);
--salt-palette-navigate-indicator-hover: var(--salt-color-gray-90);
--salt-palette-navigate-indicator-active: var(--salt-color-orange-400);
Expand Down
2 changes: 1 addition & 1 deletion site/src/examples/link/index.module.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.linkExample.linkExample:visited {
color: var(--link-color);
color: invalid-value-to-disable-visited-styles;
}

.visitedLink.visitedLink {
Expand Down

0 comments on commit 5120332

Please sign in to comment.