Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standalone ToggleButton corner radius #4091

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Sep 13, 2024

When standalone toggle button is used, it should have same corner radius as button. Only when it is used within toggle button group, it should change to match "nested" corner.

#4140

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 9:32am

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 280f967

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@salt-ds/core Patch
@salt-ds/countries Patch
@salt-ds/data-grid Patch
@salt-ds/lab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@origami-z
Copy link
Contributor Author

Take out from sprint, given design changes is also needed. Link to #4140 for work to be scheduled together

@joshwooding joshwooding force-pushed the standalone-toggle-button-corner branch from 9dd4122 to 7ee9bde Compare October 29, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants