Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpha colors #4708

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Update alpha colors #4708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55b1c12
Update alpha colours
joshwooding Feb 14, 2025
a52b347
changesets
joshwooding Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .changeset/light-oranges-knock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
"@salt-ds/theme": minor
---

Added white 20, black 20 and 40 to the legacy alpha foundation:

```css
--salt-color-white-20a: rgba(var(--salt-color-white-rgb), 0.2);
--salt-color-black-20a: rgba(var(--salt-color-black-rgb), 0.2);
--salt-color-black-40a: rgba(var(--salt-color-black-rgb), 0.4);
```

Deprecated alpha 15 and 45 tokens in white and black in both themes:

```css
--salt-color-white-15a: rgba(var(--salt-color-white-rgb), 0.15);
--salt-color-white-45a: rgba(var(--salt-color-white-rgb), 0.45);
--salt-color-black-15a: rgba(var(--salt-color-black-rgb), 0.15);
--salt-color-black-45a: rgba(var(--salt-color-black-rgb), 0.45);
```
19 changes: 19 additions & 0 deletions .changeset/short-gorillas-train.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
"@salt-ds/theme": minor
---

Rebalanced the alpha palette by updating the strong and weak tokens:

```diff
- --salt-palette-alpha-strong: var(--salt-color-black-45a);
- --salt-palette-alpha-weak: var(--salt-color-black-15a);
+ --salt-palette-alpha-strong: var(--salt-color-black-40a);
+ --salt-palette-alpha-weak: var(--salt-color-black-20a);
```

```diff
- --salt-palette-alpha-strong: var(--salt-color-white-45a);
- --salt-palette-alpha-weak: var(--salt-color-white-15a);
+ --salt-palette-alpha-strong: var(--salt-color-white-40a);
+ --salt-palette-alpha-weak: var(--salt-color-white-20a);
```
5 changes: 5 additions & 0 deletions .changeset/wise-dragons-punch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@salt-ds/theme": minor
---

Updated `--salt-track-borderColor` to be lighter in the Salt Next theme.
2 changes: 1 addition & 1 deletion packages/theme/css/characteristics/track-next.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
.salt-theme.salt-theme-next {
--salt-track-borderColor: var(--salt-palette-alpha);
--salt-track-borderColor: var(--salt-palette-alpha-weak);
}
5 changes: 5 additions & 0 deletions packages/theme/css/deprecated/fade.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,9 @@
--salt-color-black-fade-background-highlight: rgba(0, 0, 0, var(--salt-opacity-25));
--salt-color-white-fade-background-selection: rgba(255, 255, 255, var(--salt-opacity-15));
--salt-color-white-fade-background-highlight: rgba(255, 255, 255, var(--salt-opacity-25));

--salt-color-white-15a: rgba(var(--salt-color-white-rgb), 0.15);
--salt-color-white-45a: rgba(var(--salt-color-white-rgb), 0.45);
--salt-color-black-15a: rgba(var(--salt-color-black-rgb), 0.15);
--salt-color-black-45a: rgba(var(--salt-color-black-rgb), 0.45);
}
6 changes: 1 addition & 5 deletions packages/theme/css/foundations/alpha-next.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,17 @@
/*
/*
TODO: discuss whether this should be an actual file, or should inline these values.
con: If we offer these values, then it could misleading that we're offering all these values
*/
.salt-theme.salt-theme-next {
--salt-color-white-10a: rgba(var(--salt-color-white-rgb), 0.1);
--salt-color-white-15a: rgba(var(--salt-color-white-rgb), 0.15);
--salt-color-white-20a: rgba(var(--salt-color-white-rgb), 0.2);
--salt-color-white-30a: rgba(var(--salt-color-white-rgb), 0.3);
--salt-color-white-40a: rgba(var(--salt-color-white-rgb), 0.4);
--salt-color-white-45a: rgba(var(--salt-color-white-rgb), 0.45);
--salt-color-white-70a: rgba(var(--salt-color-white-rgb), 0.7);
--salt-color-black-10a: rgba(var(--salt-color-black-rgb), 0.1);
--salt-color-black-15a: rgba(var(--salt-color-black-rgb), 0.15);
--salt-color-black-20a: rgba(var(--salt-color-black-rgb), 0.2);
--salt-color-black-30a: rgba(var(--salt-color-black-rgb), 0.3);
--salt-color-black-40a: rgba(var(--salt-color-black-rgb), 0.4);
--salt-color-black-45a: rgba(var(--salt-color-black-rgb), 0.45);
--salt-color-black-70a: rgba(var(--salt-color-black-rgb), 0.7);
--salt-color-blue-200-40a: rgba(var(--salt-color-blue-200-rgb), 0.4);
--salt-color-blue-300-40a: rgba(var(--salt-color-blue-300-rgb), 0.4);
Expand Down
7 changes: 3 additions & 4 deletions packages/theme/css/foundations/alpha.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ con: If we offer these values, then it could misleading that we're offering all
*/
.salt-theme {
--salt-color-white-10a: rgba(var(--salt-color-white-rgb), 0.1);
--salt-color-white-15a: rgba(var(--salt-color-white-rgb), 0.15);
--salt-color-white-20a: rgba(var(--salt-color-white-rgb), 0.2);
--salt-color-white-30a: rgba(var(--salt-color-white-rgb), 0.3);
--salt-color-white-40a: rgba(var(--salt-color-white-rgb), 0.4);
--salt-color-white-45a: rgba(var(--salt-color-white-rgb), 0.45);
--salt-color-white-70a: rgba(var(--salt-color-white-rgb), 0.7);
--salt-color-black-10a: rgba(var(--salt-color-black-rgb), 0.1);
--salt-color-black-15a: rgba(var(--salt-color-black-rgb), 0.15);
--salt-color-black-20a: rgba(var(--salt-color-black-rgb), 0.2);
--salt-color-black-30a: rgba(var(--salt-color-black-rgb), 0.3);
--salt-color-black-45a: rgba(var(--salt-color-black-rgb), 0.45);
--salt-color-black-40a: rgba(var(--salt-color-black-rgb), 0.4);
--salt-color-black-70a: rgba(var(--salt-color-black-rgb), 0.7);
--salt-color-blue-30-40a: rgba(var(--salt-color-blue-30-rgb), 0.4);
--salt-color-blue-100-40a: rgba(var(--salt-color-blue-100-rgb), 0.4);
Expand Down
8 changes: 4 additions & 4 deletions packages/theme/css/palette/alpha.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.salt-theme[data-mode="light"] {
--salt-palette-alpha: var(--salt-color-black-30a);
--salt-palette-alpha-strong: var(--salt-color-black-45a);
--salt-palette-alpha-weak: var(--salt-color-black-15a);
--salt-palette-alpha-strong: var(--salt-color-black-40a);
--salt-palette-alpha-weak: var(--salt-color-black-20a);
--salt-palette-alpha-weaker: var(--salt-color-black-10a);

--salt-palette-alpha-backdrop: var(--salt-color-white-70a);
Expand All @@ -10,8 +10,8 @@

.salt-theme[data-mode="dark"] {
--salt-palette-alpha: var(--salt-color-white-30a);
--salt-palette-alpha-strong: var(--salt-color-white-45a);
--salt-palette-alpha-weak: var(--salt-color-white-15a);
--salt-palette-alpha-strong: var(--salt-color-white-40a);
--salt-palette-alpha-weak: var(--salt-color-white-20a);
--salt-palette-alpha-weaker: var(--salt-color-white-10a);

--salt-palette-alpha-backdrop: var(--salt-color-black-70a);
Expand Down
Loading