Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Commit

Permalink
Improve JavaScript configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
Juan Pablo Rinaldi committed May 11, 2020
1 parent ea3389e commit 8da5426
Show file tree
Hide file tree
Showing 37 changed files with 736 additions and 520 deletions.
4 changes: 3 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
**/*{.,-}min.js
coverage
public
tmp
8 changes: 8 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
module.exports = {
extends: ['plugin:prettier/recommended'],
parserOptions: {
ecmaVersion: 11,
sourceType: 'module',
},
plugins: ['prettier'],
};
277 changes: 0 additions & 277 deletions .eslintrc.yml

This file was deleted.

18 changes: 14 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
name: CI
on: [push, pull_request]
jobs:
lint:
name: Lint
lint-javascript:
name: Lint JavaScript
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: borales/[email protected]
with:
cmd: install
- name: Run ESLint
run: yarn lint
lint-ruby:
name: Lint Ruby
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
Expand Down Expand Up @@ -34,7 +44,7 @@ jobs:
services:
db:
image: postgres:12
ports: ["5432:5432"]
ports: ['5432:5432']
env:
POSTGRES_DB: HackerGateway_test
POSTGRES_USER: postgres
Expand All @@ -46,7 +56,7 @@ jobs:
--health-retries 5
redis:
image: redis
ports: ["6379:6379"]
ports: ['6379:6379']
options: --entrypoint redis-server
steps:
- uses: actions/checkout@v1
Expand Down
3 changes: 3 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
singleQuote: true,
};
1 change: 1 addition & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ Metrics/AbcSize:
Metrics/BlockLength:
Exclude:
- "config/environments/*"
- "config/initializers/content_security_policy.rb"
- "config/routes.rb"
- "spec/**/*"

Expand Down
2 changes: 0 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ gem "sassc-rails"
# Transpile app-like JavaScript
# Read more: https://github.com/rails/webpacker
gem "webpacker", "~> 5.1"
# Use CoffeeScript for .coffee assets and views
gem "coffee-rails", "~> 5.0"
# See https://github.com/rails/execjs#readme for more supported runtimes
# gem 'therubyracer', platforms: :ruby

Expand Down
9 changes: 0 additions & 9 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,6 @@ GEM
simplecov
url
coderay (1.1.2)
coffee-rails (5.0.0)
coffee-script (>= 2.2.0)
railties (>= 5.2.0)
coffee-script (2.4.1)
coffee-script-source
execjs
coffee-script-source (1.12.2)
concurrent-ruby (1.1.6)
countries (3.0.1)
i18n_data (~> 0.10.0)
Expand All @@ -137,7 +130,6 @@ GEM
dotenv (= 2.7.5)
railties (>= 3.2, < 6.1)
erubi (1.9.0)
execjs (2.7.0)
exifr (1.3.6)
factory_bot (5.2.0)
activesupport (>= 4.2.0)
Expand Down Expand Up @@ -441,7 +433,6 @@ DEPENDENCIES
capybara
cloudflare-rails
codecov
coffee-rails (~> 5.0)
country_select
coverband
devise
Expand Down
1 change: 0 additions & 1 deletion app/assets/config/manifest.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//= link_tree ../images
//= link_directory ../javascripts .js
//= link_directory ../stylesheets .css
//= link_directory ../images/favicon .json
//= link_directory ../images/favicon .xml
1 change: 0 additions & 1 deletion app/assets/javascripts/active_admin.js.coffee

This file was deleted.

Loading

0 comments on commit 8da5426

Please sign in to comment.