* Fix concurrency crash in closeAllShopWindows caused by use-after-free

jprzimba · Jan 5, 2025 · 2ffc69f · 2ffc69f
1 parent 98c72a8
commit 2ffc69f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/creatures/npcs/npc.cpp b/src/creatures/npcs/npc.cpp
@@ -828,7 +828,7 @@ void Npc::removeShopPlayer(uint32_t playerGUID) {
 }
 
 void Npc::closeAllShopWindows() {
-	for (const auto &playerGUID : shopPlayers | std::views::keys) {
+	for (const auto playerGUID : shopPlayers | std::views::keys) {
 		const auto &player = g_game().getPlayerByGUID(playerGUID);
 		if (player) {
 			player->closeShopWindow();