Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Filterable: Add a data-no-filter attribute #8185

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

carsonip
Copy link

@carsonip carsonip commented Jul 6, 2015

Add a data-no-filter attribute for an item such that it will always show in both normal and reveal mode when its data-no-filter="true"

Closes gh-8184

Add a data-no-filter attribute for an item such that it will always show in both normal and reveal mode when its data-no-filter="true"

Closes jquery-archivegh-8184
@arschmitz
Copy link
Contributor

@carsonip can you please sign the CLA?

@carsonip
Copy link
Author

@arschmitz I have signed it twice with different names but with the same correct email address. Please check.

@arschmitz
Copy link
Contributor

@carsonip thank you. We have decided to add this feature though the implementation might be a bit different. Ill review this soon and give you feedback.

@jzaefferer
Copy link
Contributor

The CLA signature is fine now.

@arschmitz
Copy link
Contributor

@carsonip sorry about the delay in this finally ready to add this feature. Im wondering if it might be better / more flexible to add an option ignore that you can set to any valid selector? thoughts?

@apsdehal
Copy link
Contributor

apsdehal commented Jul 5, 2016

I agree with @arschmitz that an option would be more convenient in this case.

@carsonip
Copy link
Author

carsonip commented Jul 12, 2016

@arschmitz Sorry for the late reply. I would love to improve the request. Could you elaborate more about the ignore option? Which element should it belong to?

@apsdehal
Copy link
Contributor

apsdehal commented Jul 12, 2016

@carsonip ignore option will have a value of string which would a valid html selector for the items which should not be filtered.

Replaced data-no-filter with data-ignore according to the comments of
jQuery members. Looks more flexible now.
@carsonip
Copy link
Author

Sorry for the wait. I have updated the PR according to the comments. Not sure if there will be a significant performance hit since we will create a jQuery object from each item such that we can use the is() function. There will certainly be no performance hit if data-ignore is not set.

@ecadius
Copy link
Contributor

ecadius commented Jan 31, 2019

What is the status of this PR? If it should be merged, who can sign the Contributor License Agreement?

Base automatically changed from master to main March 16, 2021 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants