This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Demos: Fix search navigation through keyboard #8406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ( this.element.find( "li.ui-button-active" ).length === 0 ) { | ||
| this.element.find( "li:first" ).toggleClass( "ui-button-active" ).find("a").toggleClass( "ui-button-active" ); | ||
| if ( this.element.find( "li.ui-listview-item-active" ).length === 0 ) { | ||
| this.element.find( "li:not('.ui-screen-hidden'):first" ) |
There was a problem hiding this comment.
lets simplify this to .find( "li ).not( ".ui-screen-hidden" ).first(); we generally prefer methods over selectors
|
👍 |
|
Thanks for fixing this @apsdehal ! @cogwurx has been tweaking the menu styles. I think the background color you set in this PR has to be adjusted to match his style and @cogwurx probably has to fix selectors in his PR to match your changes. See https://github.com/jquery/jquery-mobile/pull/8389/files#diff-ccdaf42db1312d7cb7e21a8bb76543d6R976. |
|
@jaspermdegroot I will fix my change, that is why I was waiting for your comment before merging it. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for a reason why
nextAll/prevAllis used againstnext/prev, follow this linkFixes #8405
Refs #8245