Решение 2х задач по 2му занятию #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавляю преподавателя (@ShGKme) для код-ревью. |
ShGKme
approved these changes
Dec 20, 2024
Comment on lines
+4
to
+6
| function getIconByConditionId(id) { | ||
| return WeatherConditionIcons[parseInt(id)] || ''; | ||
| } |
There was a problem hiding this comment.
Vue сам приводит undefined к пустой строке при выводе
Comment on lines
+8
to
+14
| function timeToSeconds(time) { | ||
| return time.split(':')[0]*60 + time.split(':')[1]*1; | ||
| } | ||
|
|
||
| function isDayNow(currientTime, sunriseTime, sunsetTime) { | ||
| return timeToSeconds(sunriseTime) < timeToSeconds(currientTime) && timeToSeconds(currientTime) < timeToSeconds(sunsetTime); | ||
| } |
There was a problem hiding this comment.
Строки в формате HH:MM можно сравнивать просто лексикографически как строки без преобразований. '08:30' < '09:12'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Решение задач к Основы: Часть 1