Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3е занятие все задачи #3

Merged
merged 13 commits into from
Dec 24, 2024
Merged

Conversation

YuGulin
Copy link

@YuGulin YuGulin commented Dec 23, 2024

[Счётчик]
[Сломанная карта]
[Калькулятор]
[Отмеченные Email-ы]
[Выбранный митап]

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 23, 2024

Добавляю преподавателя (@ShGKme) для код-ревью.

@jsru-1 jsru-1 requested a review from ShGKme December 23, 2024 23:27
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Требуются небольшие исправления в 02-basics-2/40-marked-emails

02-basics-2/40-marked-emails/MarkedEmailsApp.js Outdated Show resolved Hide resolved
02-basics-2/40-marked-emails/MarkedEmailsApp.js Outdated Show resolved Hide resolved
02-basics-2/50-selected-meetup/SelectedMeetupApp.js Outdated Show resolved Hide resolved
02-basics-2/50-selected-meetup/SelectedMeetupApp.js Outdated Show resolved Hide resolved
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 24, 2024

Добавляю преподавателя (@ShGKme) для код-ревью.

@jsru-1 jsru-1 requested a review from ShGKme December 24, 2024 21:12
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 24, 2024

Решение было обновлено, посмотрим что скажет @ShGKme

1 similar comment
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 24, 2024

Решение было обновлено, посмотрим что скажет @ShGKme

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 24, 2024

Решение было обновлено, посмотрим что скажет @ShGKme

Comment on lines +39 to +41
const arr = [];
emails.forEach(email => arr.push({emailValue: email, isFlagged: search.value && email.toLowerCase().includes(search.value.toLowerCase())}));
return arr;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь хорошо подойдёт метод массива map

@jsru-1 jsru-1 merged commit e7735e7 into js-tasks-ru:master Dec 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants