Minor refactoring of the toASCII function

jsdom · Feb 23, 2024 · 8569350 · 8569350
1 parent d6cd9a7
commit 8569350
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/index.js b/index.js
@@ -279,6 +279,7 @@ function toASCII(domainName, {
     transitionalProcessing,
     ignoreInvalidPunycode
   });
+
   let labels = result.string.split(".");
   labels = labels.map(l => {
     if (containsNonASCII(l)) {
@@ -291,23 +292,23 @@ function toASCII(domainName, {
     return l;
   });
 
+  if (result.error) {
+    return null;
+  }
+
   if (verifyDNSLength) {
     const total = labels.join(".").length;
     if (total > 253 || total === 0) {
-      result.error = true;
+      return null;
     }
 
     for (let i = 0; i < labels.length; ++i) {
       if (labels[i].length > 63 || labels[i].length === 0) {
-        result.error = true;
-        break;
+        return null;
       }
     }
   }
 
-  if (result.error) {
-    return null;
-  }
   return labels.join(".");
 }