-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 1.0.1 #58
base: master
Are you sure you want to change the base?
Release: 1.0.1 #58
Conversation
f8b4ad9
to
ff318ed
Compare
Current plan is to release it today. |
Hey @UlisesGascon , please consider adding #56 to the release. The commit removing the safe-buffer package is based on the assumption that only node versions v18 and newer are supported. |
Signed-off-by: Ulises Gascon <[email protected]>
ff318ed
to
aec927d
Compare
Added! thanks for the ping @Phillip9587 👍 |
This should technically be a major. But, because it is our states support policy that engines should have been 18 on 1.0.0 release, I am willing to bend as long as we make this a minor (not patch like it is now). |
Hey @UlisesGascon, Just wanted to kindly check if there’s an ETA for when this release might go out? Looking forward to it! |
Probably Jan'25 🎄 |
Hey @UlisesGascon, just wanted to check in on the status of this release. This is the last of Express's direct dependencies that uses the |
I will be assembling a list of releases we need to do next week. If @UlisesGascon doesn't time before then I can take this on. I will be doing two passes to make sure we release all the pending things for express first, then update them and release in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm not sure if the engine update will be in a patch or minor, but I'm sure it won't be in a patch.
Plan to release it on Nov 06
What's included in the
HISTORY.md
engines
field to Node@18 or highersafe-buffer
What's Changed
safe-buffer
by @Phillip9587 in Remove dependencysafe-buffer
#53New Contributors
safe-buffer
#53Full Changelog: v1.0.0...master