Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern JS features, ship TS defs #175

Merged
merged 2 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore

This file was deleted.

11 changes: 0 additions & 11 deletions .eslintrc.yml

This file was deleted.

261 changes: 17 additions & 244 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,253 +1,26 @@
name: ci

on:
- pull_request
- push
- pull_request
- push

jobs:
test:
runs-on: ubuntu-20.04
name: Node.js ${{ matrix.node-version }}
runs-on: ubuntu-latest
strategy:
matrix:
name:
- Node.js 0.6
- Node.js 0.8
- Node.js 0.10
- Node.js 0.12
- io.js 1.x
- io.js 2.x
- io.js 3.x
- Node.js 4.x
- Node.js 5.x
- Node.js 6.x
- Node.js 7.x
- Node.js 8.x
- Node.js 9.x
- Node.js 10.x
- Node.js 11.x
- Node.js 12.x
- Node.js 13.x
- Node.js 14.x
- Node.js 15.x
- Node.js 16.x
- Node.js 17.x
- Node.js 18.x
- Node.js 19.x
- Node.js 20.x
- Node.js 21.x

include:
- name: Node.js 0.6
node-version: "0.6"
npm-i: [email protected]
npm-rm: beautify-benchmark benchmark nyc top-sites

- name: Node.js 0.8
node-version: "0.8"
npm-i: [email protected]
npm-rm: beautify-benchmark benchmark nyc top-sites

- name: Node.js 0.10
node-version: "0.10"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 0.12
node-version: "0.12"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: io.js 1.x
node-version: "1.8"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: io.js 2.x
node-version: "2.5"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: io.js 3.x
node-version: "3.3"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 4.x
node-version: "4.9"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 5.x
node-version: "5.12"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 6.x
node-version: "6.17"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 7.x
node-version: "7.10"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 8.x
node-version: "8.17"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 9.x
node-version: "9.11"
npm-i: [email protected] [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 10.x
node-version: "10.24"
npm-i: [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 11.x
node-version: "11.15"
npm-i: [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 12.x
node-version: "12.22"
npm-i: [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 13.x
node-version: "13.14"
npm-i: [email protected]
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 14.x
node-version: "14.21"
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 15.x
node-version: "15.14"
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 16.x
node-version: "16.20"
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 17.x
node-version: "17.9"
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 18.x
node-version: "18.18"
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 19.x
node-version: "19.9"
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 20.x
node-version: "20.9"
npm-rm: beautify-benchmark benchmark top-sites

- name: Node.js 21.x
node-version: "21.1"

steps:
- uses: actions/checkout@v3

- name: Install Node.js ${{ matrix.node-version }}
shell: bash -eo pipefail -l {0}
run: |
if [[ "${{ matrix.node-version }}" == 0.6* ]]; then
sudo sh -c 'echo "deb http://us.archive.ubuntu.com/ubuntu/ bionic universe" >> /etc/apt/sources.list'
sudo sh -c 'echo "deb http://security.ubuntu.com/ubuntu bionic-security main" >> /etc/apt/sources.list'
sudo apt-get update
sudo apt-get install g++-4.8 gcc-4.8 libssl1.0-dev python2 python-is-python2
export CC=/usr/bin/gcc-4.8
export CXX=/usr/bin/g++-4.8
fi
nvm install --default ${{ matrix.node-version }}
if [[ "${{ matrix.node-version }}" == 0.* && "$(cut -d. -f2 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then
nvm install --alias=npm 0.10
nvm use ${{ matrix.node-version }}
if [[ "$(npm -v)" == 1.1.* ]]; then
nvm exec npm npm install -g [email protected]
ln -fs "$(which npm)" "$(dirname "$(nvm which npm)")/npm"
else
sed -i '1s;^.*$;'"$(printf '#!%q' "$(nvm which npm)")"';' "$(readlink -f "$(which npm)")"
fi
npm config set strict-ssl false
fi
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"

- name: Configure npm
run: |
if [[ "$(npm config get package-lock)" == "true" ]]; then
npm config set package-lock false
else
npm config set shrinkwrap false
fi

- name: Remove npm module(s) ${{ matrix.npm-rm }}
run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
if: matrix.npm-rm != ''

- name: Install npm module(s) ${{ matrix.npm-i }}
run: npm install --save-dev ${{ matrix.npm-i }}
if: matrix.npm-i != ''

- name: Setup Node.js version-specific dependencies
shell: bash
run: |
# eslint for linting
# - remove on Node.js < 12
if [[ "$(cut -d. -f1 <<< "${{ matrix.node-version }}")" -lt 12 ]]; then
node -pe 'Object.keys(require("./package").devDependencies).join("\n")' | \
grep -E '^eslint(-|$)' | \
sort -r | \
xargs -n1 npm rm --silent --save-dev
fi

- name: Install Node.js dependencies
run: npm install

- name: List environment
id: list_env
shell: bash
run: |
echo "node@$(node -v)"
echo "npm@$(npm -v)"
npm -s ls ||:
(npm -s ls --depth=0 ||:) | awk -F'[ @]' 'NR>1 && $2 { print $2 "=" $3 }' >> "$GITHUB_OUTPUT"

- name: Run tests
shell: bash
run: |
if npm -ps ls nyc | grep -q nyc; then
npm run test-ci
else
npm test
fi

- name: Lint code
if: steps.list_env.outputs.eslint != ''
run: npm run lint

- name: Collect code coverage
uses: coverallsapp/github-action@master
if: steps.list_env.outputs.nyc != ''
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
flag-name: run-${{ matrix.test_number }}
parallel: true

coverage:
needs: test
runs-on: ubuntu-latest
node-version:
- "18"
- "20"
- "22"
steps:
- name: Upload code coverage
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
parallel-finished: true
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm test
- uses: codecov/codecov-action@v4
with:
name: Node.js ${{ matrix.node-version }}
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
coverage/
node_modules/
npm-debug.log
package-lock.json
dist/
*.tsbuildinfo
Loading
Loading