New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket might never be emitted #32

Open

ronag wants to merge 1 commit into jshttp:master from ronag:fix-error-before-socket

ronag commented Jun 24, 2019

a socket might never be emitted which would cause isFinished to never complete


          msg can error before socket

be8ebec

ronag force-pushed the fix-error-before-socket branch from 466cde5 to be8ebec Compare

June 24, 2019 22:45

dougwilson added needs tests pr labels

ronag changed the title ~~msg can error before socket~~ socket might never be emitted

wesleytodd mentioned this pull request

response is only finished if socket is detached #31

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels