Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.github/workflows/config.yml: disable installing recommends in apt-get install #515

Merged
merged 3 commits into from
Dec 31, 2024
Merged

[.github/workflows/config.yml: disable installing recommends in apt-get install #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9064816
[.github/workflows/config.yml: disable installing recommends as ros-o…
k-okada Dec 30, 2024
7c8a968
[3rdparty/downward/package.xml: add linbfl-dev for FlexLexer.h
k-okada Dec 30, 2024
ed63e70
[nfc_ros] nfcpy requries python3.6+, skip kinetic which has python3.5
k-okada Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,8 @@ jobs:
apt install -qq -y python3-rosdep2
echo "yaml ${{ matrix.ROS_REPOSITORY_URL }}/local.yaml debian" | tee /etc/ros/rosdep/sources.list.d/1-ros-o-builder.list
rosdep update
# disable installing recommends as ros-o-builder do
echo 'APT::Install-Recommends "false";' | tee /etc/apt/apt.conf.d/99norecommends

- name: Setup catkin-tools
run: |
Expand Down
1 change: 1 addition & 0 deletions 3rdparty/downward/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<build_depend condition="$ROS_PYTHON_VERSION == 2">python</build_depend>
<build_depend condition="$ROS_PYTHON_VERSION == 3">python3</build_depend>
<build_depend>flex</build_depend>
<build_depend>libfl-dev</build_depend>
<build_depend>bison</build_depend>
<build_depend>gawk</build_depend>
<build_depend>rostest</build_depend>
Expand Down
4 changes: 2 additions & 2 deletions nfc_ros/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ catkin_package(
CATKIN_DEPENDS message_runtime
)

if ("$ENV{ROS_DISTRO}" MATCHES "indigo")
if ("$ENV{ROS_DISTRO}" MATCHES "indigo" OR "$ENV{ROS_DISTRO}" MATCHES "kinetic")
message(WARNING "nfc_ros requires python3.6 or newer. For indigo, virtualenv generation is skipped.")
else()
catkin_generate_virtualenv(
Expand All @@ -36,7 +36,7 @@ install(FILES requirements.txt
DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}
)

if(CATKIN_ENABLE_TESTING)
if(CATKIN_ENABLE_TESTING AND ("$ENV{ROS_DISTRO}" MATCHES "indigo" OR "$ENV{ROS_DISTRO}" MATCHES "kinetic"))
find_package(rostest REQUIRED)
add_rostest(test/test_rospy_node.test
DEPENDENCIES ${PROJECT_NAME}_generate_virtualenv
Expand Down
Loading