Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read only first X rows #106

Closed
wants to merge 2 commits into from
Closed

Read only first X rows #106

wants to merge 2 commits into from

Conversation

Thijsiez
Copy link
Contributor

@Thijsiez Thijsiez commented Aug 3, 2022

As suggested in #100, I thought it would be great to be able to read a subset of rows.
This PR adds functions that will only read the first X rows of actual data in the form of CsvReader.read(String|File|InputStream, Int) and CsvReader.readWithHeader(String|File|InputStream, Int)

Thanks for the wonderful library, hope you like my addition! :)

@Thijsiez Thijsiez changed the title Feature/read only first x rows Read only first X rows Aug 3, 2022
@doyaaaaaken
Copy link
Collaborator

Thanks so much for your contribution, but I would like to think carefully about this Issue.
To take an example, I feel that reading the first X lines is not a very frequent use case, so I'm wondering if it is correct to provide it as a public method.
I am very sorry for the PR you have made, but I would like to think about it some more, so I will close this one. 🙇

@doyaaaaaken doyaaaaaken closed this Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants