Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom 404 page implementation #100

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AQIB-NAWAB
Copy link

What kind of change does this PR introduce?
Developed a 404 page for better user experience

Issue Number:
issue #99

Screenshots/videos:
Here is output of new custom 404 page
image

http://localhost:3000/unknown-page

Summary

My main motivation to add 404 page was improving the better user experience

@AQIB-NAWAB
Copy link
Author

fix #99

Copy link
Member

@JeelRajodiya JeelRajodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the following

  • Make sure the font size is as large as we have in the design
  • Fix alignment of the subtitle as per the design
    image
  • make the borders rounded in the back to home button (as per the design)

app/not-found.tsx Outdated Show resolved Hide resolved
@AQIB-NAWAB
Copy link
Author

Here is update with figma values
image
image

@AQIB-NAWAB
Copy link
Author

@JeelRajodiya I make the necessary changes according to figma , please review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants