Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prettify code in code editor #116

Merged
merged 5 commits into from
Dec 21, 2024

Conversation

pavanydg
Copy link
Contributor

@pavanydg pavanydg commented Dec 7, 2024

What kind of change does this PR introduce?
Prettify the code in code editor every 1 second.

Issue Number:

Screenshots/videos:

Screencast.from.12-08-2024.01.22.05.AM.webm

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@pavanydg
Copy link
Contributor Author

pavanydg commented Dec 8, 2024

@JeelRajodiya pl review.

@pavanydg
Copy link
Contributor Author

@JeelRajodiya any changes required?

@JeelRajodiya
Copy link
Member

JeelRajodiya commented Dec 21, 2024

I am reviewing your PR right now. Thanks for waiting.

@JeelRajodiya
Copy link
Member

@pavanydg Well done, The feature is implemented correctly!

I had to remove the timely formatting because it was adding too may useEffects (total 6 useEffects) in the component. Intead, now it formats the code when it is being validated.

@JeelRajodiya JeelRajodiya merged commit 2757157 into json-schema-org:main Dec 21, 2024
1 check passed
@pavanydg
Copy link
Contributor Author

@JeelRajodiya Yeah sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Prettify code in the code editor
2 participants