-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: trpc 11.x support (resolves #184) #194
base: main
Are you sure you want to change the base?
Conversation
@mat-sz I tried the basic-react example from your fork. One thing that I noticed is, that I loose all state in the components upon HMR. To demonstrate this I simply added a counter to the
Why is the counter reset upon every safe of the file? Is there a way to preserve it? |
@mat-sz great! will this work with tRPC 11 Streaming? (uses a batchStreamLink) |
Just bumping this issue to see if there are any updates! Also more than happy to test and/or help! |
@enricoros @spencekim Potentially, Blob support might be a problem, I will need to look into that. |
Thanks for the answer @mat-sz, I understand now. I'd need to change some logic to be able to return an async generator form the ipc link, I think. |
Hello, why not merge yet? |
Any updates here? |
Folks, TRPC 11 is in beta and may have breaking API changes. I am not going to force consumers of electron-trpc onto the TRPC beta line. There is an electron-trpc rewrite in progress which will be at least compatible with TRPC 11, and may be backwards compatible. It may be that the 0.x version of electron-trpc will be maintained for some time for TRPC users pre-11. |
Few things worth noting:
package.json
will need to be replaced (next
->>=11.0.0
) for both@trpc/client
and@trpc/server
indevDependencies
. Otherwise tRPC 12.x unstable releases might be installed (whenever they start existing).