Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Switch to platform options from deprecated custom schema options #68

Open
wants to merge 3 commits into
base: 1.x
Choose a base branch
from

Conversation

thomas-dion-113
Copy link

Apply changes for branch 1.x (same as #64)

@maxhelias
Copy link

The maintenance effort for this version, which is already way behind, isn't worth it for this one fix.
Upgrading to version 2 doesn't seem complicated.

@thomas-dion-113
Copy link
Author

thomas-dion-113 commented May 21, 2024

The maintenance effort for this version, which is already way behind, isn't worth it for this one fix. Upgrading to version 2 doesn't seem complicated.

Upgrading to version 2 seems complicated for projects that still use php7 because it requires php8.

@maxhelias
Copy link

@thomas-dion-113 No, because requiring version 8 of php will not update the next release in your project.

@thomas-dion-113
Copy link
Author

Sorry but I don't understand, do you mean version 2 works with php7 ?

Version 1:

"php": "^5.6 || ^7.0 || ^8.0",

Version 2:

"php": "^8.0",

@maxhelias
Copy link

@thomas-dion-113 This depreciation has already been corrected in version 2, so upgrade your application to PHP 8 and, after the upgrade, update this package.
Version 1 has been inactive for almost 2 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants