Fix RegEx pattern for YouTube #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `<a href="//youtu.be/WJ88GhJJI3Q?start=4394" data-lity>Link</a>` is fired, var matches in lity.js is filled as ``` matche[0]: youtu.be/WJ88GhJJI3Q?start=4394 matche[1]: youtu.be matche[2]: undefined matche[3]: undefined matche[4]: WJ88GhJJI3Q matche[5]: ?start=4394 ``` and then, lity builds a url below which includes `%3F` as an urlencoded result of `?` in `matche[5]` so that YouTube does not start the movie at 4394. `https://www.youtube.com/embed/WJ88GhJJI3Q?autoplay=1&%3Fstart=4394` So, `var _youtubeRegex = /(youtube(-nocookie)?\.com|youtu\.be)\/(watch\?v=|v\/|u\/|embed\/?)?([\w-]{11})(.*)?/i;` should be `var _youtubeRegex = /(youtube(-nocookie)?\.com|youtu\.be)\/(watch\?v=|v\/|u\/|embed\/?)?([\w-]{11})\?(.*)?/i;` for the expected behavior.
|
Hi @nekoshippo, I'm interested in merging this into my "vanilla js" fork at https://github.com/naton/lity but unsure how to proceed. Any suggestions? Rebase this to my master there maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
<a href="//youtu.be/WJ88GhJJI3Q?start=4394" data-lity>Link</a>is fired, var matches in lity.js is filled as
and then, lity builds a url below which includes
%3Fas an urlencoded result of?inmatches[5]so that YouTube does not start the movie at 4394.https://www.youtube.com/embed/WJ88GhJJI3Q?autoplay=1&%3Fstart=4394So,
var _youtubeRegex = /(youtube(-nocookie)?\.com|youtu\.be)\/(watch\?v=|v\/|u\/|embed\/?)?([\w-]{11})(.*)?/i;should be
var _youtubeRegex = /(youtube(-nocookie)?\.com|youtu\.be)\/(watch\?v=|v\/|u\/|embed\/?)?([\w-]{11})\?(.*)?/i;for the expected behavior.