Allow to close the box while loading if loading time too long #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the loading time is too long (box trying to load an huge image on a slow network or slow ajax request whith a personal handler), the user is stuck in front of the dark loading box without any way to escape.
With the patch it is possible to close with the escape key as well as the close button while still loading.
As a result the
lity:ready
is never fired (the seems to me better than faking a ready fire) and thelity:close
is triggered onelement
instead ofcontent
.When the content is finaly loaded, it is silently ignored.