Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to close the box while loading if loading time too long #257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cerdic
Copy link

@Cerdic Cerdic commented Oct 9, 2020

When the loading time is too long (box trying to load an huge image on a slow network or slow ajax request whith a personal handler), the user is stuck in front of the dark loading box without any way to escape.

With the patch it is possible to close with the escape key as well as the close button while still loading.
As a result the lity:ready is never fired (the seems to me better than faking a ready fire) and the lity:close is triggered on element instead of content.

When the content is finaly loaded, it is silently ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant