Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option that force the focus to be inside the lity box on tab key (fix a flaw) #258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add an option that force the focus to be inside the lity box on tab key (fix a flaw) #258

wants to merge 1 commit into from

Commits on Oct 15, 2020

  1. Add an option that force the focus to be inside the lity box when the… 

    … user press tab to navigate in the page

It was possible indeed to escape the box (at least on FF) by pressing tab key several times : after going through all the focusable elements of the box, the focus goes on browser navigation buttons (previous page, address bar field) before re-entering the page on the first focusable element of the page, which is not in the lity box any more
As this is happening without a shift key the handleTabKey() doesn't fix it and then you have to go through all the page to reenter the box.
As I'm not sure if this is the expected behavior, I added an option to activate the hard forced focus in the box, but maybe this is not needed and could be the default behavior?
    @Cerdic
    Cerdic committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    5dddc1e View commit details
    Browse the repository at this point in the history