Fix: getDeepPropFromObj
does not work
#82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A following code in
getDeepPropFromObj
function inpreprocess.js
doesn't work:The
.replace()
method returns a replaced string, and it doesn't change a original string (i.e. propPath). The above code drops a replaced string.The replaced string must be received:
A current code doesn't catch the properties that is named 2 or more length when
VAR[PROP]
style is specified.For example:
Result:
A regexp in current code:
/\[([^\]+?])\]/g
This matches one character, except
]
,+
, and?
.I think that
+?
should have been a pattern not literal:/\[([^\]]+?)\]/g
And,
[^\]]
is unnecessary because?
works:/\[(.+?)\]/g
Result by the above:
A current code doesn't discern a property name via
VAR.PROP
andVAR[PROP]
, and it splits also a property name ofVAR[PROP]
.For example:
Result:
This PR discerns those.
Result by fixed code:
This fixed code discerns also a name like
VAR[AA].B[CC.DD][E]
correctly.