Skip to content

Commit

Permalink
Implemented LeastAuthority suggestion and prepared for pre-release
Browse files Browse the repository at this point in the history
    * Fixed more indentation (suggestion 1)
    * Updated release filename format
    * Fix to documentation
    * Update to processing screen
  • Loading branch information
jspada committed Jan 13, 2021
1 parent 0e59862 commit 70a46fd
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ delete:
python -m ledgerblue.deleteApp $(COMMON_DELETE_PARAMS)

release: all
@echo "Packaging release... mina-ledger-app-$(VERSION_TAG).tar.gz"
@echo "Packaging release... ledger-app-mina-$(VERSION_TAG).tar.gz"
@echo "Contents" > README
@echo " ./install.sh - Load Mina app onto Ledger device" >> README
@echo " ./uninstall.sh - Delete Mina app from Ledger device" >> README
Expand All @@ -167,9 +167,9 @@ release: all
@chmod +x install.sh uninstall.sh
@cp utils/mina_ledger_wallet.py mina_ledger_wallet
@sed -i 's/__version__ = "1.0.0"/__version__ = "$(VERSION_TAG)"/' mina_ledger_wallet
@tar -zcf mina-ledger-app-$(VERSION_TAG).tar.gz \
--transform "s,^,mina-ledger-app-$(VERSION_TAG)/," \
README \
@tar -zcf ledger-app-mina-$(VERSION_TAG).tar.gz \
--transform "s,^,ledger-app-mina-$(VERSION_TAG)/," \
README \
install.sh \
uninstall.sh \
mina_ledger_wallet \
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Continue? (y/N) y
Generating address (please confirm on Ledger device)... done
Received address: B62qpaDc8nfu4a7xghkEni8u2rBjx7EH95MFeZAhTgGofopaxFjdS7P
```
This generates the keypair corresponding to hardware wallet account 1 (BIP44 account 44'/12586'/1/0/0) and returns the corresponding Mina address.
This generates the keypair corresponding to hardware wallet account 1 (BIP44 account 44'/12586'/1'/0'/0') and returns the corresponding Mina address.

**Get balance**

Expand Down
Empty file modified prepare-devenv.sh
100755 → 100644
Empty file.
2 changes: 1 addition & 1 deletion src/get_address.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ UX_STEP_TIMEOUT(
ux_display_public_flow,
{
&C_icon_processing,
"Processing",
"Processing...",
});

UX_FLOW(ux_processing_flow,
Expand Down
4 changes: 2 additions & 2 deletions src/get_address.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
#include "globals.h"

void handle_get_address(uint8_t p1, uint8_t p2, uint8_t *dataBuffer,
uint32_t dataLength, volatile unsigned int *flags,
volatile unsigned int *tx);
uint32_t dataLength, volatile unsigned int *flags,
volatile unsigned int *tx);

0 comments on commit 70a46fd

Please sign in to comment.