Move conformance test framework code into a subproject #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpovirk
approved these changes
Nov 15, 2023
| } | ||
|
|
||
| group 'org.jspecify' | ||
| version '0.1' |
There was a problem hiding this comment.
I've liked the 0.0.0-SNAPSHOT pattern to simplify cross-project dependencies. Maybe that's not an issue, though, as long as everything involved uses Gradle and uses an include of our project? Then again, if that's the case, maybe we should be using an include for jspecify instead of a dependency on its 0.0.0-SNAPSHOT version? (Or maybe we should pick a "real" release of jspecify?)
There was a problem hiding this comment.
I was doing what Gradle suggests for now. I think it's more work to set up a Maven artifact, which we will have to do later anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #107.