[Fix] no-redundant-roles: Refine implicit role of select to include combobox scenarios
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de `combobox` scenarios Encode implicit roles for `select` elements based on roles defined in https://www.w3.org/TR/html-aria/#el-select - `select` (with a multiple attribute or a size attribute having value greater than 1) will have the implicit role 'listbox' - `select` (with NO multiple attribute and NO size attribute having value greater than 1) will have the implicit role 'combobox' Fixes jsx-eslint#949
lb-
force-pushed
the
fix/949-implicit-role-select
branch
from
94f3e3f
to
c1e47c1
Compare
MichaelDeBoey
approved these changes
Oct 25, 2024
ljharb
reviewed
Oct 25, 2024
lb-
force-pushed
the
fix/949-implicit-role-select
branch
2 times, most recently
from
bdc1cf4
to
59f4396
Compare
ljharb
approved these changes
Oct 27, 2024
ljharb
force-pushed
the
fix/949-implicit-role-select
branch
from
59f4396
to
d13725d
Compare
ljharb
changed the title
select to include combobox scenariosno-redundant-roles: Refine implicit role of select to include combobox scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode implicit roles for
selectelements based on roles defined in https://www.w3.org/TR/html-aria/#el-selectselect(with a multiple attribute or a size attribute having value greater than 1) will have the implicit role 'listbox'select(with NO multiple attribute and NO size attribute having value greater than 1) will have the implicit role 'combobox'Fixes #949