Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Add attributes setting #979

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

edoardocavazza
Copy link
Contributor

@edoardocavazza edoardocavazza commented Apr 15, 2024

This Pull Request replaces PR #977 and introduces a global setting to configure attributes, as suggested here.

It allows for attribute support for label-has-associated-control rule.

Related: #894, fixes #961

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be a bit confused; i was suggesting only a setting, and no rule config changes at all.

docs/rules/label-has-associated-control.md Outdated Show resolved Hide resolved
flow/eslint.js Show resolved Hide resolved
@edoardocavazza
Copy link
Contributor Author

Uh I am sorry, I thought it was a good idea to make the rule configurable too. I'll drop rule options, keeping the global setting.

@ljharb ljharb changed the title Add attributes setting [New] Add attributes setting Sep 4, 2024
@ljharb ljharb merged commit a1ee7f8 into jsx-eslint:main Sep 4, 2024
208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsx-a11y/label-has-associated-control gives error when for is put
3 participants