-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Add attributes
setting
#979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be a bit confused; i was suggesting only a setting, and no rule config changes at all.
Uh I am sorry, I thought it was a good idea to make the rule configurable too. I'll drop rule options, keeping the global setting. |
ljharb
force-pushed
the
attributes-setting
branch
from
September 4, 2024 05:25
ef13138
to
a1ee7f8
Compare
ljharb
approved these changes
Sep 4, 2024
amethystens
approved these changes
Sep 4, 2024
amethystens
approved these changes
Sep 4, 2024
amethystens
approved these changes
Sep 4, 2024
amethystens
approved these changes
Sep 4, 2024
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request replaces PR #977 and introduces a global setting to configure attributes, as suggested here.
It allows
for
attribute support forlabel-has-associated-control
rule.Related: #894, fixes #961