Split boofuzz/sessions.py #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, I think it'd be better to merge these independently as I don't have a timeline on when I have more code to share. |
SR4ven
requested changes
Aug 21, 2022
|
@mistressofjellyfish This is just splitting into several files? LGTM. Agree on merging and making other changes separately. Let's fix the Stickler issues like @SR4ven mentioned and get it merged. Cheers! |
SR4ven
approved these changes
Oct 4, 2023
|
Thanks again @hackathi! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the plan behind this madness, see #637.
Tox says everything is fine with splitting this module into a subpackage. I'll mark this PR as WIP and add to it as I get stuff done.