Handle TLS handshake timeouts in SSLSocketConnection #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSLSocketConnection prior to this commit would hang identifitly if a timeout during the TLS handshake occurs. This can happen if a target accepts a TCP connection but does not send any TLS handshake messages, e.g. because of a bug triggered by the fuzzing. This commit makes boofuzz observe timeouts during the TLS handshake. TLS handshake timeouts are handled in the same way as timeouts during TCP connection setup.
|
In order to reproduce the problem that this pull request is trying to fix, use the following setup: Run netcat in one shell: Run example/fuzz_ssl_client.py Observation: The connection to the netcat instance is created, but netcat does not respond to the TLS handshake. The fuzzer will hang forever. After this commit, this hanging will result in a proper error. |
|
Thank you for the PR @constcast, nice catch! I just reformatted the code according to black. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSLSocketConnection prior to this commit would hang identifitly if a timeout during the TLS handshake occurs. This can happen if a target accepts a TCP connection but does not send any TLS handshake messages, e.g. because of a bug triggered by the fuzzing.
This commit makes boofuzz observe timeouts during the TLS handshake. TLS handshake timeouts are handled in the same way as timeouts during TCP connection setup.