feat: graceful group member change #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuhui zhang <[email protected]>
zxh326
force-pushed
the
graceful-shut-down-worker
branch
2 times, most recently
from
2e09cc1 to
e74bb58
Compare
Signed-off-by: Xuhui zhang <[email protected]>
zxh326
force-pushed
the
graceful-shut-down-worker
branch
from
e74bb58 to
cb2d4e2
Compare
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
zwwhdls
reviewed
Dec 4, 2024
Signed-off-by: Xuhui zhang <[email protected]>
zxh326
force-pushed
the
graceful-shut-down-worker
branch
from
09c2867 to
2b67114
Compare
zwwhdls
approved these changes
Dec 5, 2024
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the total number of workers is 2 or more, include the
group-backupoption for new workers. Remove it after a 10-minute.If
blockcache.bytesis greater than zero, recreate the worker and updategroup-weightto zero and wait forblockcache.bytesto reach zero before deleting it.ref： https://github.com/juicedata/voc/issues/369#issuecomment-2472333654