generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use .tar.gz files where available for faster win install #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/faster_win_install
branch
2 times, most recently
from
November 17, 2023 04:40
b39e1b4
to
0ed1d0c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Nov 20, 2023
IanButterworth
changed the title
use zip files for faster win install
Use .tar.gz files where available for faster win install
Nov 21, 2023
IanButterworth
force-pushed
the
ib/faster_win_install
branch
5 times, most recently
from
November 21, 2023 03:35
235b12b
to
7321742
Compare
IanButterworth
force-pushed
the
ib/faster_win_install
branch
from
November 21, 2023 03:45
7321742
to
a911a68
Compare
Nice! |
Nice indeed! |
I need a review approval to merge. |
KristofferC
approved these changes
Nov 21, 2023
Ah yeah, that very useful feature.... Also, I'm a pleb so my review is no good. |
Seems it needs to come from someone in the org |
Merged
ViralBShah
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently takes almost a minute to install julia on windows via the .exe installer.
.zip takes ~42 seconds
.tar.gz takes ~12s 🎉
So let's use
.tar.gz
which is available all the way back to julia v1, and the exe if notCloses #64